Clean shutdown when multilang deamen is terminated by giving one last chance to checkpoint.
This commit is contained in:
parent
8d339bdb88
commit
19f3326823
3 changed files with 42 additions and 2 deletions
|
|
@ -140,11 +140,27 @@ public class MultiLangDaemon implements Callable<Integer> {
|
||||||
ExecutorService executorService = config.getExecutorService();
|
ExecutorService executorService = config.getExecutorService();
|
||||||
|
|
||||||
// Daemon
|
// Daemon
|
||||||
MultiLangDaemon daemon = new MultiLangDaemon(
|
final MultiLangDaemon daemon = new MultiLangDaemon(
|
||||||
config.getKinesisClientLibConfiguration(),
|
config.getKinesisClientLibConfiguration(),
|
||||||
config.getRecordProcessorFactory(),
|
config.getRecordProcessorFactory(),
|
||||||
executorService);
|
executorService);
|
||||||
|
|
||||||
|
Runtime.getRuntime().addShutdownHook(new Thread()
|
||||||
|
{
|
||||||
|
@Override
|
||||||
|
public void run()
|
||||||
|
{
|
||||||
|
LOG.info("Process terminanted, will initiate shutdown.");
|
||||||
|
try {
|
||||||
|
Future<Void> fut = daemon.worker.requestShutdown();
|
||||||
|
fut.get();
|
||||||
|
LOG.info("Process shutdown is complete.");
|
||||||
|
} catch (InterruptedException | ExecutionException e) {
|
||||||
|
LOG.error("Encountered an error during shutdown.", e);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
Future<Integer> future = executorService.submit(daemon);
|
Future<Integer> future = executorService.submit(daemon);
|
||||||
try {
|
try {
|
||||||
System.exit(future.get());
|
System.exit(future.get());
|
||||||
|
|
|
||||||
|
|
@ -20,6 +20,10 @@ import java.util.concurrent.ExecutionException;
|
||||||
import java.util.concurrent.ExecutorService;
|
import java.util.concurrent.ExecutorService;
|
||||||
import java.util.concurrent.Future;
|
import java.util.concurrent.Future;
|
||||||
|
|
||||||
|
import com.amazonaws.services.kinesis.clientlibrary.exceptions.InvalidStateException;
|
||||||
|
import com.amazonaws.services.kinesis.clientlibrary.exceptions.ShutdownException;
|
||||||
|
import com.amazonaws.services.kinesis.clientlibrary.interfaces.IRecordProcessorCheckpointer;
|
||||||
|
import com.amazonaws.services.kinesis.clientlibrary.interfaces.v2.IShutdownNotificationAware;
|
||||||
import org.apache.commons.logging.Log;
|
import org.apache.commons.logging.Log;
|
||||||
import org.apache.commons.logging.LogFactory;
|
import org.apache.commons.logging.LogFactory;
|
||||||
|
|
||||||
|
|
@ -29,13 +33,14 @@ import com.amazonaws.services.kinesis.clientlibrary.types.ProcessRecordsInput;
|
||||||
import com.amazonaws.services.kinesis.clientlibrary.types.ShutdownInput;
|
import com.amazonaws.services.kinesis.clientlibrary.types.ShutdownInput;
|
||||||
import com.fasterxml.jackson.databind.ObjectMapper;
|
import com.fasterxml.jackson.databind.ObjectMapper;
|
||||||
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* A record processor that manages creating a child process that implements the multi language protocol and connecting
|
* A record processor that manages creating a child process that implements the multi language protocol and connecting
|
||||||
* that child process's input and outputs to a {@link MultiLangProtocol} object and calling the appropriate methods on
|
* that child process's input and outputs to a {@link MultiLangProtocol} object and calling the appropriate methods on
|
||||||
* that object when its corresponding {@link #initialize}, {@link #processRecords}, and {@link #shutdown} methods are
|
* that object when its corresponding {@link #initialize}, {@link #processRecords}, and {@link #shutdown} methods are
|
||||||
* called.
|
* called.
|
||||||
*/
|
*/
|
||||||
public class MultiLangRecordProcessor implements IRecordProcessor {
|
public class MultiLangRecordProcessor implements IRecordProcessor, IShutdownNotificationAware {
|
||||||
|
|
||||||
private static final Log LOG = LogFactory.getLog(MultiLangRecordProcessor.class);
|
private static final Log LOG = LogFactory.getLog(MultiLangRecordProcessor.class);
|
||||||
private static final int EXIT_VALUE = 1;
|
private static final int EXIT_VALUE = 1;
|
||||||
|
|
@ -136,6 +141,24 @@ public class MultiLangRecordProcessor implements IRecordProcessor {
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public void shutdownRequested(IRecordProcessorCheckpointer checkpointer) {
|
||||||
|
LOG.info("Shutdown is requested.");
|
||||||
|
if (!initialized) {
|
||||||
|
LOG.info("Record processor was not initialized so no need to initiate a final checkpoint.");
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
try {
|
||||||
|
LOG.info("Requesting a checkpoint on shutdown notification.");
|
||||||
|
checkpointer.checkpoint();
|
||||||
|
} catch (InvalidStateException e) {
|
||||||
|
LOG.error("Checkpoint triggered during shutdown encountered InvalidStateException: " + e.toString());
|
||||||
|
} catch (ShutdownException e) {
|
||||||
|
LOG.error("Checkpoint triggered during shutdown encountered ShutdownException: " + e.toString());
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Used to tell whether the processor has been shutdown already.
|
* Used to tell whether the processor has been shutdown already.
|
||||||
*/
|
*/
|
||||||
|
|
|
||||||
|
|
@ -172,6 +172,7 @@ public class StreamingRecordProcessorTest {
|
||||||
recordProcessor.initialize(new InitializationInput().withShardId(shardId));
|
recordProcessor.initialize(new InitializationInput().withShardId(shardId));
|
||||||
recordProcessor.processRecords(new ProcessRecordsInput().withRecords(testRecords).withCheckpointer(unimplementedCheckpointer));
|
recordProcessor.processRecords(new ProcessRecordsInput().withRecords(testRecords).withCheckpointer(unimplementedCheckpointer));
|
||||||
recordProcessor.processRecords(new ProcessRecordsInput().withRecords(testRecords).withCheckpointer(unimplementedCheckpointer));
|
recordProcessor.processRecords(new ProcessRecordsInput().withRecords(testRecords).withCheckpointer(unimplementedCheckpointer));
|
||||||
|
recordProcessor.shutdownRequested(Mockito.mock(IRecordProcessorCheckpointer.class));
|
||||||
recordProcessor.shutdown(new ShutdownInput().withCheckpointer(unimplementedCheckpointer).withShutdownReason(ShutdownReason.ZOMBIE));
|
recordProcessor.shutdown(new ShutdownInput().withCheckpointer(unimplementedCheckpointer).withShutdownReason(ShutdownReason.ZOMBIE));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue