From 205cf051f3ecca8049a3150b4cd6c31e242225cf Mon Sep 17 00:00:00 2001
From: Sahil Palvia <spalvia1990@gmail.com>
Date: Wed, 15 Aug 2018 11:14:15 -0700
Subject: [PATCH] Cleaning up LeaseManagementConfig (#366)

* Cleaning up LeaseManagementConfig:

* Removing unused metrics factory variable from LeaseManagementConfig.

* Revert "Cleaning up LeaseManagementConfig:"

This reverts commit b16ba3796607525092a2b95d6fb3ad230e7cff11.

* Deprecating metrics factory in LeaseManagementConfig

* Marking metrics factory in LeaseManagementConfig for deprecation
---
 .../kinesis/leases/LeaseManagementConfig.java | 34 +++++++++++++++++--
 1 file changed, 31 insertions(+), 3 deletions(-)

diff --git a/amazon-kinesis-client/src/main/java/software/amazon/kinesis/leases/LeaseManagementConfig.java b/amazon-kinesis-client/src/main/java/software/amazon/kinesis/leases/LeaseManagementConfig.java
index ccaa2ec9..a56a6d5e 100644
--- a/amazon-kinesis-client/src/main/java/software/amazon/kinesis/leases/LeaseManagementConfig.java
+++ b/amazon-kinesis-client/src/main/java/software/amazon/kinesis/leases/LeaseManagementConfig.java
@@ -170,11 +170,39 @@ public class LeaseManagementConfig {
     private long listShardsCacheAllowedAgeInSeconds = 30;
     private int cacheMissWarningModulus = 250;
 
-    /**
-     *
-     */
     private MetricsFactory metricsFactory = new NullMetricsFactory();
 
+    /**
+     * Returns the metrics factory.
+     *
+     * <p>
+     * NOTE: This method is deprecated and will be removed in a future release. This metrics factory is not being used
+     * in the KCL.
+     * </p>
+     *
+     * @return
+     */
+    @Deprecated
+    public MetricsFactory metricsFactory() {
+        return metricsFactory;
+    }
+
+    /**
+     * Sets the metrics factory.
+     *
+     * <p>
+     * NOTE: This method is deprecated and will be removed in a future release. This metrics factory is not being used
+     * in the KCL.
+     * </p>
+     *
+     * @param metricsFactory
+     */
+    @Deprecated
+    public LeaseManagementConfig metricsFactory(final MetricsFactory metricsFactory) {
+        this.metricsFactory = metricsFactory;
+        return this;
+    }
+
     /**
      * The {@link ExecutorService} to be used by {@link ShardSyncTaskManager}.
      *