diff --git a/amazon-kinesis-client-multilang/src/test/java/software/amazon/kinesis/multilang/config/MultiLangDaemonConfigurationTest.java b/amazon-kinesis-client-multilang/src/test/java/software/amazon/kinesis/multilang/config/MultiLangDaemonConfigurationTest.java index ebc5fb17..1c45eb6e 100644 --- a/amazon-kinesis-client-multilang/src/test/java/software/amazon/kinesis/multilang/config/MultiLangDaemonConfigurationTest.java +++ b/amazon-kinesis-client-multilang/src/test/java/software/amazon/kinesis/multilang/config/MultiLangDaemonConfigurationTest.java @@ -33,6 +33,7 @@ import software.amazon.kinesis.retrieval.polling.PollingConfig; import static org.hamcrest.CoreMatchers.equalTo; import static org.hamcrest.CoreMatchers.instanceOf; import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertThat; import static org.junit.Assert.assertTrue; @@ -100,25 +101,47 @@ public class MultiLangDaemonConfigurationTest { } @Test - public void testSetLeaseTableDeletionProtectionEnabled() { + public void testSetLeaseTableDeletionProtectionEnabledToTrue() { MultiLangDaemonConfiguration configuration = baseConfiguration(); configuration.setLeaseTableDeletionProtectionEnabled(true); MultiLangDaemonConfiguration.ResolvedConfiguration resolvedConfiguration = configuration.resolvedConfiguration(shardRecordProcessorFactory); - assertThat(resolvedConfiguration.leaseManagementConfig.leaseTableDeletionProtectionEnabled(), equalTo(true)); + assertTrue(resolvedConfiguration.leaseManagementConfig.leaseTableDeletionProtectionEnabled()); } @Test - public void testSetLeaseTablePitrEnabled() { + public void testSetLeaseTablePitrEnabledToTrue() { MultiLangDaemonConfiguration configuration = baseConfiguration(); configuration.setLeaseTablePitrEnabled(true); MultiLangDaemonConfiguration.ResolvedConfiguration resolvedConfiguration = configuration.resolvedConfiguration(shardRecordProcessorFactory); - assertThat(resolvedConfiguration.leaseManagementConfig.leaseTablePitrEnabled(), equalTo(true)); + assertTrue(resolvedConfiguration.leaseManagementConfig.leaseTablePitrEnabled()); + } + + @Test + public void testSetLeaseTableDeletionProtectionEnabledToFalse() { + MultiLangDaemonConfiguration configuration = baseConfiguration(); + configuration.setLeaseTableDeletionProtectionEnabled(false); + + MultiLangDaemonConfiguration.ResolvedConfiguration resolvedConfiguration = + configuration.resolvedConfiguration(shardRecordProcessorFactory); + + assertFalse(resolvedConfiguration.leaseManagementConfig.leaseTableDeletionProtectionEnabled()); + } + + @Test + public void testSetLeaseTablePitrEnabledToFalse() { + MultiLangDaemonConfiguration configuration = baseConfiguration(); + configuration.setLeaseTablePitrEnabled(false); + + MultiLangDaemonConfiguration.ResolvedConfiguration resolvedConfiguration = + configuration.resolvedConfiguration(shardRecordProcessorFactory); + + assertFalse(resolvedConfiguration.leaseManagementConfig.leaseTablePitrEnabled()); } @Test diff --git a/amazon-kinesis-client/src/main/java/software/amazon/kinesis/leases/dynamodb/DynamoDBLeaseRefresher.java b/amazon-kinesis-client/src/main/java/software/amazon/kinesis/leases/dynamodb/DynamoDBLeaseRefresher.java index c380468e..123f4068 100644 --- a/amazon-kinesis-client/src/main/java/software/amazon/kinesis/leases/dynamodb/DynamoDBLeaseRefresher.java +++ b/amazon-kinesis-client/src/main/java/software/amazon/kinesis/leases/dynamodb/DynamoDBLeaseRefresher.java @@ -40,7 +40,6 @@ import software.amazon.awssdk.services.dynamodb.model.DynamoDbException; import software.amazon.awssdk.services.dynamodb.model.GetItemRequest; import software.amazon.awssdk.services.dynamodb.model.GetItemResponse; import software.amazon.awssdk.services.dynamodb.model.LimitExceededException; -import software.amazon.awssdk.services.dynamodb.model.PointInTimeRecoverySpecification; import software.amazon.awssdk.services.dynamodb.model.ProvisionedThroughput; import software.amazon.awssdk.services.dynamodb.model.ProvisionedThroughputExceededException; import software.amazon.awssdk.services.dynamodb.model.PutItemRequest; @@ -305,9 +304,7 @@ public class DynamoDBLeaseRefresher implements LeaseRefresher { private void enablePitr() throws DependencyException { final UpdateContinuousBackupsRequest request = UpdateContinuousBackupsRequest.builder() .tableName(table) - .pointInTimeRecoverySpecification(PointInTimeRecoverySpecification.builder() - .pointInTimeRecoveryEnabled(true) - .build()) + .pointInTimeRecoverySpecification(builder -> builder.pointInTimeRecoveryEnabled(true)) .build(); final AWSExceptionManager exceptionManager = createExceptionManager(); diff --git a/amazon-kinesis-client/src/test/java/software/amazon/kinesis/leases/dynamodb/DynamoDBLeaseRefresherTest.java b/amazon-kinesis-client/src/test/java/software/amazon/kinesis/leases/dynamodb/DynamoDBLeaseRefresherTest.java index f385cf30..2668918c 100644 --- a/amazon-kinesis-client/src/test/java/software/amazon/kinesis/leases/dynamodb/DynamoDBLeaseRefresherTest.java +++ b/amazon-kinesis-client/src/test/java/software/amazon/kinesis/leases/dynamodb/DynamoDBLeaseRefresherTest.java @@ -45,7 +45,6 @@ import software.amazon.awssdk.services.dynamodb.model.DynamoDbException; import software.amazon.awssdk.services.dynamodb.model.GetItemRequest; import software.amazon.awssdk.services.dynamodb.model.GetItemResponse; import software.amazon.awssdk.services.dynamodb.model.LimitExceededException; -import software.amazon.awssdk.services.dynamodb.model.PointInTimeRecoverySpecification; import software.amazon.awssdk.services.dynamodb.model.ProvisionedThroughput; import software.amazon.awssdk.services.dynamodb.model.PutItemRequest; import software.amazon.awssdk.services.dynamodb.model.PutItemResponse; @@ -151,9 +150,7 @@ public class DynamoDBLeaseRefresherTest { .build(); updateContinuousBackupsRequest = UpdateContinuousBackupsRequest.builder() .tableName(TABLE_NAME) - .pointInTimeRecoverySpecification(PointInTimeRecoverySpecification.builder() - .pointInTimeRecoveryEnabled(PITR_ENABLED) - .build()) + .pointInTimeRecoverySpecification(builder -> builder.pointInTimeRecoveryEnabled(PITR_ENABLED)) .build(); }