Adding default.

This commit is contained in:
jushkem 2020-02-10 10:40:09 -08:00
parent 0d45170734
commit 3691237d89
6 changed files with 6 additions and 52 deletions

View file

@ -68,14 +68,18 @@ public interface RecordsPublisher extends Publisher<RecordsRetrieved> {
* *
* @return requestId associated with last succesful response. * @return requestId associated with last succesful response.
*/ */
String getLastSuccessfulResponseRequestId(); default String getLastSuccessfulResponseRequestId() {
return getLastSuccessfulResponseDetails().map(RequestDetails::requestId).orElse(NONE);
}
/** /**
* Gets last successful response's timestamp. * Gets last successful response's timestamp.
* *
* @return timestamp associated with last successful response. * @return timestamp associated with last successful response.
*/ */
String getLastSuccessfulResponseTimestamp(); default String getLastSuccessfulResponseTimestamp() {
return getLastSuccessfulResponseDetails().map(RequestDetails::timestamp).orElse(NONE);
}
/** /**
* Notify the publisher on receipt of a data event. * Notify the publisher on receipt of a data event.

View file

@ -156,16 +156,6 @@ public class FanOutRecordsPublisher implements RecordsPublisher {
lastSuccessfulRequestDetails = Optional.of(requestDetails); lastSuccessfulRequestDetails = Optional.of(requestDetails);
} }
@Override
public String getLastSuccessfulResponseRequestId() {
return getLastSuccessfulResponseDetails().map(RequestDetails::requestId).orElse(NONE);
}
@Override
public String getLastSuccessfulResponseTimestamp() {
return getLastSuccessfulResponseDetails().map(RequestDetails::timestamp).orElse(NONE);
}
// This method is not thread-safe. You need to acquire a lock in the caller in order to execute this. // This method is not thread-safe. You need to acquire a lock in the caller in order to execute this.
@VisibleForTesting @VisibleForTesting
RecordFlow evictAckedEventAndScheduleNextEvent(RecordsDeliveryAck recordsDeliveryAck) { RecordFlow evictAckedEventAndScheduleNextEvent(RecordsDeliveryAck recordsDeliveryAck) {

View file

@ -77,16 +77,6 @@ public class BlockingRecordsPublisher implements RecordsPublisher {
return Optional.empty(); return Optional.empty();
} }
@Override
public String getLastSuccessfulResponseRequestId() {
return NONE;
}
@Override
public String getLastSuccessfulResponseTimestamp() {
return NONE;
}
@Override @Override
public void subscribe(Subscriber<? super RecordsRetrieved> s) { public void subscribe(Subscriber<? super RecordsRetrieved> s) {
subscriber = s; subscriber = s;

View file

@ -267,16 +267,6 @@ public class PrefetchRecordsPublisher implements RecordsPublisher {
return Optional.empty(); return Optional.empty();
} }
@Override
public String getLastSuccessfulResponseRequestId() {
return NONE;
}
@Override
public String getLastSuccessfulResponseTimestamp() {
return NONE;
}
@Override @Override
public void restartFrom(RecordsRetrieved recordsRetrieved) { public void restartFrom(RecordsRetrieved recordsRetrieved) {
if (!(recordsRetrieved instanceof PrefetchRecordsRetrieved)) { if (!(recordsRetrieved instanceof PrefetchRecordsRetrieved)) {

View file

@ -563,16 +563,6 @@ public class ShardConsumerSubscriberTest {
return Optional.empty(); return Optional.empty();
} }
@Override
public String getLastSuccessfulResponseRequestId() {
return NONE;
}
@Override
public String getLastSuccessfulResponseTimestamp() {
return NONE;
}
@Override @Override
public void subscribe(Subscriber<? super RecordsRetrieved> s) { public void subscribe(Subscriber<? super RecordsRetrieved> s) {
subscriber = s; subscriber = s;

View file

@ -215,16 +215,6 @@ public class ShardConsumerTest {
return Optional.empty(); return Optional.empty();
} }
@Override
public String getLastSuccessfulResponseRequestId() {
return NONE;
}
@Override
public String getLastSuccessfulResponseTimestamp() {
return NONE;
}
@Override @Override
public void subscribe(Subscriber<? super RecordsRetrieved> s) { public void subscribe(Subscriber<? super RecordsRetrieved> s) {
subscriber = s; subscriber = s;