luciano/amazon-kinesis-client
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Adding default.

Browse source
This commit is contained in:
jushkem 2020-02-10 10:40:09 -08:00
parent 0d45170734
commit 3691237d89
6 changed files with 6 additions and 52 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
amazon-kinesis-client/src/main/java/software/amazon/kinesis/retrieval/RecordsPublisher.java
View file

@ -68,14 +68,18 @@ public interface RecordsPublisher extends Publisher<RecordsRetrieved> {
*
* @return requestId associated with last succesful response.
*/
String getLastSuccessfulResponseRequestId();
default String getLastSuccessfulResponseRequestId() {
return getLastSuccessfulResponseDetails().map(RequestDetails::requestId).orElse(NONE);
}
/**
* Gets last successful response's timestamp.
*
* @return timestamp associated with last successful response.
*/
String getLastSuccessfulResponseTimestamp();
default String getLastSuccessfulResponseTimestamp() {
return getLastSuccessfulResponseDetails().map(RequestDetails::timestamp).orElse(NONE);
}
/**
* Notify the publisher on receipt of a data event.

10
amazon-kinesis-client/src/main/java/software/amazon/kinesis/retrieval/fanout/FanOutRecordsPublisher.java
View file

@ -156,16 +156,6 @@ public class FanOutRecordsPublisher implements RecordsPublisher {
lastSuccessfulRequestDetails = Optional.of(requestDetails);
}
@Override
public String getLastSuccessfulResponseRequestId() {
return getLastSuccessfulResponseDetails().map(RequestDetails::requestId).orElse(NONE);
}
@Override
public String getLastSuccessfulResponseTimestamp() {
return getLastSuccessfulResponseDetails().map(RequestDetails::timestamp).orElse(NONE);
}
// This method is not thread-safe. You need to acquire a lock in the caller in order to execute this.
@VisibleForTesting
RecordFlow evictAckedEventAndScheduleNextEvent(RecordsDeliveryAck recordsDeliveryAck) {

10
amazon-kinesis-client/src/main/java/software/amazon/kinesis/retrieval/polling/BlockingRecordsPublisher.java
View file

@ -77,16 +77,6 @@ public class BlockingRecordsPublisher implements RecordsPublisher {
return Optional.empty();
}
@Override
public String getLastSuccessfulResponseRequestId() {
return NONE;
}
@Override
public String getLastSuccessfulResponseTimestamp() {
return NONE;
}
@Override
public void subscribe(Subscriber<? super RecordsRetrieved> s) {
subscriber = s;

10
amazon-kinesis-client/src/main/java/software/amazon/kinesis/retrieval/polling/PrefetchRecordsPublisher.java
View file

@ -267,16 +267,6 @@ public class PrefetchRecordsPublisher implements RecordsPublisher {
return Optional.empty();
}
@Override
public String getLastSuccessfulResponseRequestId() {
return NONE;
}
@Override
public String getLastSuccessfulResponseTimestamp() {
return NONE;
}
@Override
public void restartFrom(RecordsRetrieved recordsRetrieved) {
if (!(recordsRetrieved instanceof PrefetchRecordsRetrieved)) {

10
amazon-kinesis-client/src/test/java/software/amazon/kinesis/lifecycle/ShardConsumerSubscriberTest.java
View file

@ -563,16 +563,6 @@ public class ShardConsumerSubscriberTest {
return Optional.empty();
}
@Override
public String getLastSuccessfulResponseRequestId() {
return NONE;
}
@Override
public String getLastSuccessfulResponseTimestamp() {
return NONE;
}
@Override
public void subscribe(Subscriber<? super RecordsRetrieved> s) {
subscriber = s;

10
amazon-kinesis-client/src/test/java/software/amazon/kinesis/lifecycle/ShardConsumerTest.java
View file

@ -215,16 +215,6 @@ public class ShardConsumerTest {
return Optional.empty();
}
@Override
public String getLastSuccessfulResponseRequestId() {
return NONE;
}
@Override
public String getLastSuccessfulResponseTimestamp() {
return NONE;
}
@Override
public void subscribe(Subscriber<? super RecordsRetrieved> s) {
subscriber = s;