Adding comments for metric and Todo works

This commit is contained in:
Chunxue Yang 2020-03-25 12:19:47 -07:00
parent 98d2f946f4
commit 391532da31
2 changed files with 6 additions and 0 deletions

View file

@ -375,6 +375,9 @@ public class Scheduler implements Runnable {
private void waitUntilHashRangeCovered() throws InterruptedException {
// TODO: Currently this call is not in use. We may need to implement this method later. Created SIM to track the work: https://sim.amazon.com/issues/KinesisLTR-202
// TODO: For future implementation, streamToShardSyncTaskManagerMap might not contain the most up to date snapshot of active streams.
// Should use currentStreamConfigMap to determine the streams to check.
while (!leaderElectedPeriodicShardSyncManager.hashRangeCovered()) {
// wait until entire hash range is covered
log.info("Hash range is not covered yet. Checking again in {} ms", HASH_RANGE_COVERAGE_CHECK_FREQUENCY_MILLIS);

View file

@ -76,6 +76,9 @@ public class ShardSyncTask implements ConsumerTask {
exception = e;
shardSyncSuccess = false;
} finally {
// NOTE: This metric is reflecting if a shard sync task succeeds. Customer can use this metric to monitor if
// their application encounter any shard sync failures. This metric can help to detect potential shard stuck issues
// that are due to shard sync failures.
MetricsUtil.addSuccess(scope, "SyncShards", shardSyncSuccess, MetricsLevel.DETAILED);
MetricsUtil.endScope(scope);
}