luciano/amazon-kinesis-client
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix backwards compatibility check (#1361)

Browse source
This commit is contained in:
nakulj 2024-07-12 09:46:49 -07:00 committed by GitHub
parent 57dcddf10b
commit 3b5c59ec04
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
.github/scripts/backwards_compatibility_check.sh vendored
View file

@ -67,7 +67,16 @@ find_removed_methods() {
then then
echo "New minor release is being performed. Ignoring changes in classes marked with @KinesisClientInternalApi annotation." echo "New minor release is being performed. Ignoring changes in classes marked with @KinesisClientInternalApi annotation."
fi fi
local latest_classes=$(jar tf $LATEST_JAR | grep .class | tr / . | sed 's/\.class$//') local latest_classes=$(
jar tf $LATEST_JAR |
grep .class |
tr / . |
sed 's/\.class$//' |
# skip generated proto classes since these have a lot of inherited methods
# that are not outputted by javap. besides, generated java code is not a
# good indicator of proto compatibility- it will not capture reserved
# tags or deprecated fields.
grep -v 'software\.amazon\.kinesis\.retrieval\.kpl\.Messages')
for class in $latest_classes for class in $latest_classes
do do
if (is_kinesis_client_internal_api "$class" && is_new_minor_release) || is_non_public_class "$class" if (is_kinesis_client_internal_api "$class" && is_new_minor_release) || is_non_public_class "$class"
@ -83,7 +92,7 @@ find_removed_methods() {
local removed_methods=$(diff <(echo "$LATEST_METHODS") <(echo "$CURRENT_METHODS") | grep '^<') local removed_methods=$(diff <(echo "$LATEST_METHODS") <(echo "$CURRENT_METHODS") | grep '^<')
# ignore synthetic access methods - these are not available to users and will not break backwards compatibility # ignore synthetic access methods - these are not available to users and will not break backwards compatibility
removed_methods=$(echo "$removed_methods" | grep -v "access\$[0-9]00") removed_methods=$(echo "$removed_methods" | grep -v "access\$[0-9]\+")
if [[ "$removed_methods" != "" ]] if [[ "$removed_methods" != "" ]]
then then
@ -116,4 +125,4 @@ main() {
get_backwards_compatible_result get_backwards_compatible_result
} }
main main