From a8fa3387cc10449a72386b2c467690ff1e6488bf Mon Sep 17 00:00:00 2001 From: Nakul Joshi Date: Tue, 21 May 2024 17:28:31 -0700 Subject: [PATCH 1/4] Set the source encoding in the pom. This stops the following warning from being emitted in our logs: ``` [WARNING] File encoding has not been set, using platform encoding UTF-8, i.e. build is platform dependent! ``` --- pom.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/pom.xml b/pom.xml index 272d29cf..e41a2de1 100644 --- a/pom.xml +++ b/pom.xml @@ -34,6 +34,7 @@ 2.25.11 + UTF-8 From 6cafbb30890ea97ce397131da97bfc684e39802e Mon Sep 17 00:00:00 2001 From: Nakul Joshi Date: Tue, 28 May 2024 08:15:43 -0700 Subject: [PATCH 2/4] fix warning ``` Not generating getSchedulerInitializationBackoffTimeMillis(): A method with that name already exists ``` --- .../kinesis/coordinator/KinesisClientLibConfiguration.java | 7 ------- 1 file changed, 7 deletions(-) diff --git a/amazon-kinesis-client-multilang/src/main/java/software/amazon/kinesis/coordinator/KinesisClientLibConfiguration.java b/amazon-kinesis-client-multilang/src/main/java/software/amazon/kinesis/coordinator/KinesisClientLibConfiguration.java index 179eb9e4..2bc6a5b8 100644 --- a/amazon-kinesis-client-multilang/src/main/java/software/amazon/kinesis/coordinator/KinesisClientLibConfiguration.java +++ b/amazon-kinesis-client-multilang/src/main/java/software/amazon/kinesis/coordinator/KinesisClientLibConfiguration.java @@ -966,13 +966,6 @@ public class KinesisClientLibConfiguration { return shutdownGraceMillis; } - /** - * @return Interval in milliseconds between retrying the scheduler initialization. - */ - public long getSchedulerInitializationBackoffTimeMillis() { - return schedulerInitializationBackoffTimeMillis; - } - /* * // CHECKSTYLE:IGNORE HiddenFieldCheck FOR NEXT 190 LINES * /** From 9adc8a1d4b21ff49a1a26a3c99802ed04ac7b0ef Mon Sep 17 00:00:00 2001 From: Nakul Joshi Date: Thu, 30 May 2024 10:00:40 -0700 Subject: [PATCH 3/4] fix varargs invocation --- .../config/AWSCredentialsProviderPropertyValueDecoder.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/amazon-kinesis-client-multilang/src/main/java/software/amazon/kinesis/multilang/config/AWSCredentialsProviderPropertyValueDecoder.java b/amazon-kinesis-client-multilang/src/main/java/software/amazon/kinesis/multilang/config/AWSCredentialsProviderPropertyValueDecoder.java index 8110d4f7..6d924cce 100644 --- a/amazon-kinesis-client-multilang/src/main/java/software/amazon/kinesis/multilang/config/AWSCredentialsProviderPropertyValueDecoder.java +++ b/amazon-kinesis-client-multilang/src/main/java/software/amazon/kinesis/multilang/config/AWSCredentialsProviderPropertyValueDecoder.java @@ -98,7 +98,7 @@ class AWSCredentialsProviderPropertyValueDecoder implements IPropertyValueDecode provider = constructProvider(providerName, () -> { Class[] argTypes = new Class[nameAndArgs.length - 1]; Arrays.fill(argTypes, String.class); - return clazz.getConstructor(argTypes).newInstance(varargs); + return clazz.getConstructor(argTypes).newInstance((Object[]) varargs); }); if (provider == null) { From feacf03f93f75d0e29dddafdb4ec1016a6b58f5b Mon Sep 17 00:00:00 2001 From: Nakul Joshi Date: Thu, 30 May 2024 14:46:01 -0700 Subject: [PATCH 4/4] Fail on warnings --- amazon-kinesis-client-multilang/pom.xml | 1 + amazon-kinesis-client/pom.xml | 1 + 2 files changed, 2 insertions(+) diff --git a/amazon-kinesis-client-multilang/pom.xml b/amazon-kinesis-client-multilang/pom.xml index e213c3fd..51b2f481 100644 --- a/amazon-kinesis-client-multilang/pom.xml +++ b/amazon-kinesis-client-multilang/pom.xml @@ -134,6 +134,7 @@ 8 UTF-8 + true diff --git a/amazon-kinesis-client/pom.xml b/amazon-kinesis-client/pom.xml index e34095c3..d8778c30 100644 --- a/amazon-kinesis-client/pom.xml +++ b/amazon-kinesis-client/pom.xml @@ -189,6 +189,7 @@ 8 UTF-8 + true