luciano/amazon-kinesis-client
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Added comments on the garbage cleanup logic - 2

Browse source
This commit is contained in:
Ashwin Giridharan 2020-06-15 22:02:33 -07:00
parent 7b0dc0d3e5
commit 4d65f56038
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
amazon-kinesis-client/src/main/java/software/amazon/kinesis/lifecycle/ShutdownTask.java
View file

@ -146,6 +146,7 @@ public class ShutdownTask implements ConsumerTask {
// in the case of RNF Exception. // in the case of RNF Exception.
attemptShardEndCheckpointing(scope, startTime); attemptShardEndCheckpointing(scope, startTime);
} finally { } finally {
// Attempt to garbage collect if this shard is no longer associated with the stream.
// If we don't want to cleanup the garbage shard without successful shard end // If we don't want to cleanup the garbage shard without successful shard end
// checkpointing, remove the try finally construct and only execute the methods. // checkpointing, remove the try finally construct and only execute the methods.
attemptGarbageCollectionOfLeaseAndEnqueueOnFailure(leasePendingDeletion, currentShardLease); attemptGarbageCollectionOfLeaseAndEnqueueOnFailure(leasePendingDeletion, currentShardLease);