luciano/amazon-kinesis-client
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Updating to new version of AWS SDK 2.10.56, changing Netty client defaults. (#679)

Browse source 
* Updating AWS SDK version to 2.10.56

* Changing default netty client to use 60 second ping health check timeout and 10MB initial window size.

* Tuning default request response timeout to 60 seconds.
This commit is contained in:
Joshua Kim 2020-01-28 11:00:51 -08:00 committed by GitHub
parent 1a2932cc5a
commit 66f5204d84
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 13 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
amazon-kinesis-client/src/main/java/software/amazon/kinesis/common/KinesisClientUtil.java
View file

@ -15,15 +15,22 @@
package software.amazon.kinesis.common; package software.amazon.kinesis.common;
import software.amazon.awssdk.http.Protocol;
import software.amazon.awssdk.http.nio.netty.Http2Configuration;
import software.amazon.awssdk.http.nio.netty.NettyNioAsyncHttpClient; import software.amazon.awssdk.http.nio.netty.NettyNioAsyncHttpClient;
import software.amazon.awssdk.services.kinesis.KinesisAsyncClient; import software.amazon.awssdk.services.kinesis.KinesisAsyncClient;
import software.amazon.awssdk.services.kinesis.KinesisAsyncClientBuilder; import software.amazon.awssdk.services.kinesis.KinesisAsyncClientBuilder;
import java.time.Duration;
/** /**
* Utility to setup KinesisAsyncClient to be used with KCL. * Utility to setup KinesisAsyncClient to be used with KCL.
*/ */
public class KinesisClientUtil { public class KinesisClientUtil {
private static int INITIAL_WINDOW_SIZE_BYTES = 10 * 1024 * 1024;
private static long HEALTH_CHECK_PING_PERIOD_MILLIS = 60 * 1000;
/** /**
* Creates a client from a builder. * Creates a client from a builder.
* *
@ -35,6 +42,9 @@ public class KinesisClientUtil {
} }
public static KinesisAsyncClientBuilder adjustKinesisClientBuilder(KinesisAsyncClientBuilder builder) { public static KinesisAsyncClientBuilder adjustKinesisClientBuilder(KinesisAsyncClientBuilder builder) {
return builder.httpClientBuilder(NettyNioAsyncHttpClient.builder().maxConcurrency(Integer.MAX_VALUE)); return builder.httpClientBuilder(NettyNioAsyncHttpClient.builder().maxConcurrency(Integer.MAX_VALUE)
.http2Configuration(Http2Configuration.builder().initialWindowSize(INITIAL_WINDOW_SIZE_BYTES)
.healthCheckPingPeriod(Duration.ofMillis(HEALTH_CHECK_PING_PERIOD_MILLIS)).build())
.protocol(Protocol.HTTP2));
} }
} }

2
amazon-kinesis-client/src/main/java/software/amazon/kinesis/lifecycle/ShardConsumer.java
View file

@ -52,7 +52,7 @@ import software.amazon.kinesis.retrieval.RecordsPublisher;
@KinesisClientInternalApi @KinesisClientInternalApi
public class ShardConsumer { public class ShardConsumer {
public static final int MAX_TIME_BETWEEN_REQUEST_RESPONSE = 35000; public static final int MAX_TIME_BETWEEN_REQUEST_RESPONSE = 60 * 1000;
private final RecordsPublisher recordsPublisher; private final RecordsPublisher recordsPublisher;
private final ExecutorService executorService; private final ExecutorService executorService;
private final ShardInfo shardInfo; private final ShardInfo shardInfo;

2
pom.xml
View file

@ -33,7 +33,7 @@
</scm> </scm>
<properties> <properties>
<awssdk.version>2.10.25</awssdk.version> <awssdk.version>2.10.56</awssdk.version>
</properties> </properties>
<licenses> <licenses>