Additional Comments about Worker Shutdown
Added some additional comments clarifying the shutdown check miss.
This commit is contained in:
parent
0d1279829e
commit
6fb204d507
1 changed files with 10 additions and 1 deletions
|
|
@ -105,10 +105,19 @@ class ShutdownFuture implements Future<Void> {
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* This checks to see if the worker has already hit it's shutdown target, while there is outstanding record
|
||||||
|
* processors. This maybe a little racy due to when the value of outstanding is retrieved. In general though the
|
||||||
|
* latch should be decremented before the shutdown completion.
|
||||||
|
*
|
||||||
|
* @param outstanding
|
||||||
|
* the number of record processor still awaiting shutdown.
|
||||||
|
* @return the number of record processors awaiting shutdown, or 0 if the worker believes it's shutdown already.
|
||||||
|
*/
|
||||||
private long checkWorkerShutdownMiss(long outstanding) {
|
private long checkWorkerShutdownMiss(long outstanding) {
|
||||||
if (isWorkerShutdownComplete()) {
|
if (isWorkerShutdownComplete()) {
|
||||||
if (outstanding != 0) {
|
if (outstanding != 0) {
|
||||||
log.warn("Shutdown completed, but shutdownCompleteLatch still had outstanding " + outstanding
|
log.info("Shutdown completed, but shutdownCompleteLatch still had outstanding " + outstanding
|
||||||
+ " with a current value of " + shutdownCompleteLatch.getCount() + ". shutdownComplete: "
|
+ " with a current value of " + shutdownCompleteLatch.getCount() + ". shutdownComplete: "
|
||||||
+ worker.isShutdownComplete() + " -- Consumer Map: "
|
+ worker.isShutdownComplete() + " -- Consumer Map: "
|
||||||
+ worker.getShardInfoShardConsumerMap().size());
|
+ worker.getShardInfoShardConsumerMap().size());
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue