luciano/amazon-kinesis-client
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix backwards compatibility check

Browse source
This commit is contained in:
Nakul Joshi 2024-07-02 15:35:49 -07:00
parent f507066ea6
commit 707bc25a88
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
.github/scripts/backwards_compatibility_check.sh vendored
View file

@ -67,7 +67,12 @@ find_removed_methods() {
then
echo "New minor release is being performed. Ignoring changes in classes marked with @KinesisClientInternalApi annotation."
fi
local latest_classes=$(jar tf $LATEST_JAR | grep .class | tr / . | sed 's/\.class$//')
local latest_classes=$(
jar tf $LATEST_JAR |
grep .class |
tr / . | sed 's/\.class$//' |
# skip generated proto classes since these have a lot of inherited methods that are not outputted by javap.
grep -v 'software\.amazon\.kinesis\.retrieval\.kpl\.Messages')
for class in $latest_classes
do
if (is_kinesis_client_internal_api "$class" && is_new_minor_release) || is_non_public_class "$class"
@ -83,7 +88,7 @@ find_removed_methods() {
local removed_methods=$(diff <(echo "$LATEST_METHODS") <(echo "$CURRENT_METHODS") | grep '^<')
# ignore synthetic access methods - these are not available to users and will not break backwards compatibility
removed_methods=$(echo "$removed_methods" | grep -v "access\$[0-9]00")
removed_methods=$(echo "$removed_methods" | grep -v "access\$[0-9]+")
if [[ "$removed_methods" != "" ]]
then