Added comments on the garbage cleanup logic

This commit is contained in:
Ashwin Giridharan 2020-06-15 22:00:56 -07:00
parent 8ec14baca1
commit 7b0dc0d3e5

View file

@ -146,6 +146,8 @@ public class ShutdownTask implements ConsumerTask {
// in the case of RNF Exception. // in the case of RNF Exception.
attemptShardEndCheckpointing(scope, startTime); attemptShardEndCheckpointing(scope, startTime);
} finally { } finally {
// If we don't want to cleanup the garbage shard without successful shard end
// checkpointing, remove the try finally construct and only execute the methods.
attemptGarbageCollectionOfLeaseAndEnqueueOnFailure(leasePendingDeletion, currentShardLease); attemptGarbageCollectionOfLeaseAndEnqueueOnFailure(leasePendingDeletion, currentShardLease);
} }
} }