From 7c7491c30d844d700a0e830ace2924686dd9903a Mon Sep 17 00:00:00 2001 From: Joshua Kim <20001595+jushkem@users.noreply.github.com> Date: Mon, 23 Mar 2020 09:34:26 -0700 Subject: [PATCH] Adding subscribe to shard request id logging to ShardConsumerSubscriber. (#705) --- .../amazon/kinesis/lifecycle/ShardConsumerSubscriber.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/amazon-kinesis-client/src/main/java/software/amazon/kinesis/lifecycle/ShardConsumerSubscriber.java b/amazon-kinesis-client/src/main/java/software/amazon/kinesis/lifecycle/ShardConsumerSubscriber.java index 4c05ac94..cb70024d 100644 --- a/amazon-kinesis-client/src/main/java/software/amazon/kinesis/lifecycle/ShardConsumerSubscriber.java +++ b/amazon-kinesis-client/src/main/java/software/amazon/kinesis/lifecycle/ShardConsumerSubscriber.java @@ -192,8 +192,8 @@ class ShardConsumerSubscriber implements Subscriber { protected void logOnErrorWarning(Throwable t) { log.warn( "{}: onError(). Cancelling subscription, and marking self as failed. KCL will " - + "recreate the subscription as neccessary to continue processing.", - shardConsumer.shardInfo().shardId(), t); + + "recreate the subscription as neccessary to continue processing. Last successful request details -- {}", + shardConsumer.shardInfo().shardId(), recordsPublisher.getLastSuccessfulRequestDetails(), t); } protected void logOnErrorReadTimeoutWarning(Throwable t) { @@ -202,7 +202,8 @@ class ShardConsumerSubscriber implements Subscriber { + "are seeing this warning frequently consider increasing the SDK timeouts " + "by providing an OverrideConfiguration to the kinesis client. Alternatively you" + "can configure LifecycleConfig.readTimeoutsToIgnoreBeforeWarning to suppress" - + "intermittant ReadTimeout warnings.", shardConsumer.shardInfo().shardId(), t); + + "intermittant ReadTimeout warnings. Last successful request details -- {}", + shardConsumer.shardInfo().shardId(), recordsPublisher.getLastSuccessfulRequestDetails(), t); } @Override