luciano/amazon-kinesis-client
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Addressing comments and fixing the failing test.

Browse source
This commit is contained in:
Sahil Palvia 2017-09-21 13:23:22 -07:00
parent 48699f4812
commit 7d24bc54f8
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/main/java/com/amazonaws/services/kinesis/clientlibrary/lib/worker/PrefetchGetRecordsCache.java
View file

@ -137,7 +137,7 @@ public class PrefetchGetRecordsCache implements GetRecordsCache {
return result.getRecords().stream().mapToLong(record -> record.getData().array().length).sum(); return result.getRecords().stream().mapToLong(record -> record.getData().array().length).sum();
} }
public boolean shouldGetNewRecords() { public synchronized boolean shouldGetNewRecords() {
return size < maxRecordsCount && byteSize < maxByteSize; return size < maxRecordsCount && byteSize < maxByteSize;
} }
} }

6
src/test/java/com/amazonaws/services/kinesis/clientlibrary/lib/worker/BlockingGetRecordsCacheTest.java
View file

@ -51,11 +51,11 @@ public class BlockingGetRecordsCacheTest {
@Before @Before
public void setup() { public void setup() {
when(getRecordsRetrievalStrategy.getRecords(eq(MAX_RECORDS_PER_COUNT))).thenReturn(getRecordsResult);
when(getRecordsResult.getRecords()).thenReturn(records);
records = new ArrayList<>(); records = new ArrayList<>();
blockingGetRecordsCache = new BlockingGetRecordsCache(MAX_RECORDS_PER_COUNT, getRecordsRetrievalStrategy); blockingGetRecordsCache = new BlockingGetRecordsCache(MAX_RECORDS_PER_COUNT, getRecordsRetrievalStrategy);
when(getRecordsRetrievalStrategy.getRecords(eq(MAX_RECORDS_PER_COUNT))).thenReturn(getRecordsResult);
when(getRecordsResult.getRecords()).thenReturn(records);
} }
@Test @Test