luciano/amazon-kinesis-client
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Losing the leases correctly instead of updating them multiple times to lose it.

Browse source
This commit is contained in:
Sahil Palvia 2017-08-15 11:37:15 -07:00
parent 359b810601
commit 813916a2c1
2 changed files with 4 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/test/java/com/amazonaws/services/kinesis/leases/impl/LeaseIntegrationTest.java
View file

@ -72,9 +72,4 @@ public class LeaseIntegrationTest {
} }
}; };
protected void loseLease(KinesisClientLease lease) throws LeasingException {
// Need to call update 2 times because 1st time would be considered to be spurious update for the lease.
leaseManager.updateLease(lease);
leaseManager.updateLease(lease);
}
} }

8
src/test/java/com/amazonaws/services/kinesis/leases/impl/LeaseRenewerIntegrationTest.java
View file

@ -58,7 +58,7 @@ public class LeaseRenewerIntegrationTest extends LeaseIntegrationTest {
KinesisClientLease renewedLease = builder.renewMutateAssert(renewer, "1", "2").get("2"); KinesisClientLease renewedLease = builder.renewMutateAssert(renewer, "1", "2").get("2");
// lose lease 2 // lose lease 2
loseLease(renewedLease); leaseManager.takeLease(renewedLease, "bar");
builder.renewMutateAssert(renewer, "1"); builder.renewMutateAssert(renewer, "1");
} }
@ -108,7 +108,7 @@ public class LeaseRenewerIntegrationTest extends LeaseIntegrationTest {
Assert.assertEquals((Long) 1L, heldLeases.get("2").getLeaseCounter()); Assert.assertEquals((Long) 1L, heldLeases.get("2").getLeaseCounter());
// lose lease 2 // lose lease 2
loseLease(lease2); leaseManager.takeLease(lease2, "bar");
// Do another renewal and make sure the copy doesn't change // Do another renewal and make sure the copy doesn't change
builder.renewMutateAssert(renewer, "1"); builder.renewMutateAssert(renewer, "1");
@ -179,7 +179,7 @@ public class LeaseRenewerIntegrationTest extends LeaseIntegrationTest {
KinesisClientLease lease = renewer.getCurrentlyHeldLease("1"); KinesisClientLease lease = renewer.getCurrentlyHeldLease("1");
// cause lease loss such that the renewer knows the lease has been lost when update is called // cause lease loss such that the renewer knows the lease has been lost when update is called
loseLease(lease); leaseManager.takeLease(lease, "bar");
builder.renewMutateAssert(renewer); builder.renewMutateAssert(renewer);
lease.setCheckpoint(new ExtendedSequenceNumber("new checkpoint")); lease.setCheckpoint(new ExtendedSequenceNumber("new checkpoint"));
@ -198,7 +198,7 @@ public class LeaseRenewerIntegrationTest extends LeaseIntegrationTest {
KinesisClientLease lease = renewer.getCurrentlyHeldLease("1"); KinesisClientLease lease = renewer.getCurrentlyHeldLease("1");
// cause lease loss such that the renewer knows the lease has been lost when update is called // cause lease loss such that the renewer knows the lease has been lost when update is called
loseLease(lease); leaseManager.takeLease(lease, "bar");
builder.renewMutateAssert(renewer); builder.renewMutateAssert(renewer);
// regain the lease // regain the lease