luciano/amazon-kinesis-client
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Extending ShardConsumer class constructor to have ConsumerTaskFactory as a param (#1463)

Browse source
This commit is contained in:
Abhi Gupta 2025-04-15 01:27:58 +05:30 committed by GitHub
parent 6990fc513f
commit 897d993782
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 18 additions and 34 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
amazon-kinesis-client/src/main/java/software/amazon/kinesis/coordinator/Scheduler.java
View file

@ -1167,7 +1167,8 @@ public class Scheduler implements Runnable {
lifecycleConfig.logWarningForTaskAfterMillis(),
argument,
lifecycleConfig.taskExecutionListener(),
lifecycleConfig.readTimeoutsToIgnoreBeforeWarning());
lifecycleConfig.readTimeoutsToIgnoreBeforeWarning(),
leaseManagementConfig.consumerTaskFactory());
}
/**

34
amazon-kinesis-client/src/main/java/software/amazon/kinesis/lifecycle/ShardConsumer.java
View file

@ -88,6 +88,9 @@ public class ShardConsumer {
private final ConsumerTaskFactory taskFactory;
//
// TODO: Make bufferSize configurable
//
public ShardConsumer(
RecordsPublisher recordsPublisher,
ExecutorService executorService,
@ -95,7 +98,8 @@ public class ShardConsumer {
Optional<Long> logWarningForTaskAfterMillis,
ShardConsumerArgument shardConsumerArgument,
TaskExecutionListener taskExecutionListener,
int readTimeoutsToIgnoreBeforeWarning) {
int readTimeoutsToIgnoreBeforeWarning,
ConsumerTaskFactory consumerTaskFactory) {
this(
recordsPublisher,
executorService,
@ -106,33 +110,7 @@ public class ShardConsumer {
8,
taskExecutionListener,
readTimeoutsToIgnoreBeforeWarning,
new KinesisConsumerTaskFactory());
}
//
// TODO: Make bufferSize configurable
//
public ShardConsumer(
RecordsPublisher recordsPublisher,
ExecutorService executorService,
ShardInfo shardInfo,
Optional<Long> logWarningForTaskAfterMillis,
ShardConsumerArgument shardConsumerArgument,
ConsumerState initialState,
int bufferSize,
TaskExecutionListener taskExecutionListener,
int readTimeoutsToIgnoreBeforeWarning) {
this(
recordsPublisher,
executorService,
shardInfo,
logWarningForTaskAfterMillis,
shardConsumerArgument,
initialState,
bufferSize,
taskExecutionListener,
readTimeoutsToIgnoreBeforeWarning,
new KinesisConsumerTaskFactory());
consumerTaskFactory);
}
public ShardConsumer(

3
amazon-kinesis-client/src/test/java/software/amazon/kinesis/lifecycle/ConsumerStatesTest.java
View file

@ -167,7 +167,8 @@ public class ConsumerStatesTest {
logWarningForTaskAfterMillis,
argument,
taskExecutionListener,
0));
0,
new KinesisConsumerTaskFactory()));
when(recordProcessorCheckpointer.checkpointer()).thenReturn(checkpointer);
}

12
amazon-kinesis-client/src/test/java/software/amazon/kinesis/lifecycle/ShardConsumerTest.java
View file

@ -781,7 +781,8 @@ public class ShardConsumerTest {
initialState,
1,
taskExecutionListener,
0);
0,
new KinesisConsumerTaskFactory());
mockSuccessfulInitialize(null);
mockSuccessfulProcessing(null);
@ -836,7 +837,8 @@ public class ShardConsumerTest {
initialState,
1,
taskExecutionListener,
0);
0,
new KinesisConsumerTaskFactory());
CyclicBarrier taskArriveBarrier = new CyclicBarrier(2);
CyclicBarrier taskDepartBarrier = new CyclicBarrier(2);
@ -943,7 +945,8 @@ public class ShardConsumerTest {
mockState,
1,
taskExecutionListener,
0);
0,
new KinesisConsumerTaskFactory());
when(mockState.state()).thenReturn(ShardConsumerState.WAITING_ON_PARENT_SHARDS);
when(mockState.taskType()).thenReturn(TaskType.BLOCK_ON_PARENT_SHARDS);
@ -1155,6 +1158,7 @@ public class ShardConsumerTest {
state,
1,
taskExecutionListener,
0);
0,
new KinesisConsumerTaskFactory());
}
}