luciano/amazon-kinesis-client
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #57 from Renjuju/cherry-pick-leases-list-to-set

Browse source 
[Cherry-pick] Convert expiredLeases to set (#56)
This commit is contained in:
ashwing 2020-06-16 10:19:45 -07:00 committed by GitHub
commit a24e7dcf03
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
amazon-kinesis-client/src/main/java/software/amazon/kinesis/leases/dynamodb/DynamoDBLeaseTaker.java
View file

@ -499,10 +499,13 @@ public class DynamoDBLeaseTaker implements LeaseTaker {
*/ */
private Map<String, Integer> computeLeaseCounts(List<Lease> expiredLeases) { private Map<String, Integer> computeLeaseCounts(List<Lease> expiredLeases) {
Map<String, Integer> leaseCounts = new HashMap<>(); Map<String, Integer> leaseCounts = new HashMap<>();
// The set will give much faster lookup than the original list, an
// important optimization when the list is large
Set<Lease> expiredLeasesSet = new HashSet<>(expiredLeases);
// Compute the number of leases per worker by looking through allLeases and ignoring leases that have expired. // Compute the number of leases per worker by looking through allLeases and ignoring leases that have expired.
for (Lease lease : allLeases.values()) { for (Lease lease : allLeases.values()) {
if (!expiredLeases.contains(lease)) { if (!expiredLeasesSet.contains(lease)) {
String leaseOwner = lease.leaseOwner(); String leaseOwner = lease.leaseOwner();
Integer oldCount = leaseCounts.get(leaseOwner); Integer oldCount = leaseCounts.get(leaseOwner);
if (oldCount == null) { if (oldCount == null) {