Adding backward compatible constructors that use the default DDB Billing Mode (#673)
Co-authored-by: cobrads <44237866+cobrads@users.noreply.github.com>
This commit is contained in:
parent
ca15bd4ef5
commit
a7079a81e4
2 changed files with 38 additions and 0 deletions
|
|
@ -15,6 +15,7 @@
|
||||||
package com.amazonaws.services.kinesis.leases.impl;
|
package com.amazonaws.services.kinesis.leases.impl;
|
||||||
|
|
||||||
import com.amazonaws.services.dynamodbv2.model.BillingMode;
|
import com.amazonaws.services.dynamodbv2.model.BillingMode;
|
||||||
|
import com.amazonaws.services.kinesis.clientlibrary.lib.worker.KinesisClientLibConfiguration;
|
||||||
import org.apache.commons.logging.Log;
|
import org.apache.commons.logging.Log;
|
||||||
import org.apache.commons.logging.LogFactory;
|
import org.apache.commons.logging.LogFactory;
|
||||||
|
|
||||||
|
|
@ -33,6 +34,17 @@ public class KinesisClientLeaseManager extends LeaseManager<KinesisClientLease>
|
||||||
@SuppressWarnings("unused")
|
@SuppressWarnings("unused")
|
||||||
private static final Log LOG = LogFactory.getLog(KinesisClientLeaseManager.class);
|
private static final Log LOG = LogFactory.getLog(KinesisClientLeaseManager.class);
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Constructor.
|
||||||
|
*
|
||||||
|
* @param table Leases table
|
||||||
|
* @param dynamoDBClient DynamoDB client to use
|
||||||
|
*/
|
||||||
|
@Deprecated
|
||||||
|
public KinesisClientLeaseManager(String table, AmazonDynamoDB dynamoDBClient) {
|
||||||
|
this(table, dynamoDBClient, false, KinesisClientLibConfiguration.DEFAULT_DDB_BILLING_MODE);
|
||||||
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Constructor.
|
* Constructor.
|
||||||
*
|
*
|
||||||
|
|
@ -43,6 +55,19 @@ public class KinesisClientLeaseManager extends LeaseManager<KinesisClientLease>
|
||||||
this(table, dynamoDBClient, false, billingMode);
|
this(table, dynamoDBClient, false, billingMode);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Constructor for integration tests - see comment on superclass for documentation on setting the consistentReads
|
||||||
|
* flag.
|
||||||
|
*
|
||||||
|
* @param table leases table
|
||||||
|
* @param dynamoDBClient DynamoDB client to use
|
||||||
|
* @param consistentReads true if we want consistent reads for testing purposes.
|
||||||
|
*/
|
||||||
|
@Deprecated
|
||||||
|
public KinesisClientLeaseManager(String table, AmazonDynamoDB dynamoDBClient, boolean consistentReads) {
|
||||||
|
super(table, dynamoDBClient, new KinesisClientLeaseSerializer(), consistentReads, KinesisClientLibConfiguration.DEFAULT_DDB_BILLING_MODE);
|
||||||
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Constructor for integration tests - see comment on superclass for documentation on setting the consistentReads
|
* Constructor for integration tests - see comment on superclass for documentation on setting the consistentReads
|
||||||
* flag.
|
* flag.
|
||||||
|
|
|
||||||
|
|
@ -20,6 +20,7 @@ import java.util.Map;
|
||||||
import java.util.concurrent.TimeUnit;
|
import java.util.concurrent.TimeUnit;
|
||||||
|
|
||||||
import com.amazonaws.services.dynamodbv2.model.BillingMode;
|
import com.amazonaws.services.dynamodbv2.model.BillingMode;
|
||||||
|
import com.amazonaws.services.kinesis.clientlibrary.lib.worker.KinesisClientLibConfiguration;
|
||||||
import com.amazonaws.services.kinesis.leases.util.DynamoUtils;
|
import com.amazonaws.services.kinesis.leases.util.DynamoUtils;
|
||||||
import org.apache.commons.logging.Log;
|
import org.apache.commons.logging.Log;
|
||||||
import org.apache.commons.logging.LogFactory;
|
import org.apache.commons.logging.LogFactory;
|
||||||
|
|
@ -64,6 +65,18 @@ public class LeaseManager<T extends Lease> implements ILeaseManager<T> {
|
||||||
protected boolean consistentReads;
|
protected boolean consistentReads;
|
||||||
private BillingMode billingMode;
|
private BillingMode billingMode;
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Constructor.
|
||||||
|
*
|
||||||
|
* @param table leases table
|
||||||
|
* @param dynamoDBClient DynamoDB client to use
|
||||||
|
* @param serializer LeaseSerializer to use to convert to/from DynamoDB objects.
|
||||||
|
*/
|
||||||
|
@Deprecated
|
||||||
|
public LeaseManager(String table, AmazonDynamoDB dynamoDBClient, ILeaseSerializer<T> serializer) {
|
||||||
|
this(table, dynamoDBClient, serializer, false, KinesisClientLibConfiguration.DEFAULT_DDB_BILLING_MODE);
|
||||||
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Constructor.
|
* Constructor.
|
||||||
*
|
*
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue