luciano/amazon-kinesis-client
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Adding backward compatible constructors that use the default DDB Billing Mode (#673)

Browse source 
Co-authored-by: cobrads <44237866+cobrads@users.noreply.github.com>
This commit is contained in:
Cory-Bradshaw 2020-01-09 10:10:06 -08:00 committed by GitHub
parent ca15bd4ef5
commit a7079a81e4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 38 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
src/main/java/com/amazonaws/services/kinesis/leases/impl/KinesisClientLeaseManager.java
View file

@ -15,6 +15,7 @@
package com.amazonaws.services.kinesis.leases.impl;
import com.amazonaws.services.dynamodbv2.model.BillingMode;
import com.amazonaws.services.kinesis.clientlibrary.lib.worker.KinesisClientLibConfiguration;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
@ -33,6 +34,17 @@ public class KinesisClientLeaseManager extends LeaseManager<KinesisClientLease>
@SuppressWarnings("unused")
private static final Log LOG = LogFactory.getLog(KinesisClientLeaseManager.class);
/**
* Constructor.
*
* @param table Leases table
* @param dynamoDBClient DynamoDB client to use
*/
@Deprecated
public KinesisClientLeaseManager(String table, AmazonDynamoDB dynamoDBClient) {
this(table, dynamoDBClient, false, KinesisClientLibConfiguration.DEFAULT_DDB_BILLING_MODE);
}
/**
* Constructor.
*
@ -43,6 +55,19 @@ public class KinesisClientLeaseManager extends LeaseManager<KinesisClientLease>
this(table, dynamoDBClient, false, billingMode);
}
/**
* Constructor for integration tests - see comment on superclass for documentation on setting the consistentReads
* flag.
*
* @param table leases table
* @param dynamoDBClient DynamoDB client to use
* @param consistentReads true if we want consistent reads for testing purposes.
*/
@Deprecated
public KinesisClientLeaseManager(String table, AmazonDynamoDB dynamoDBClient, boolean consistentReads) {
super(table, dynamoDBClient, new KinesisClientLeaseSerializer(), consistentReads, KinesisClientLibConfiguration.DEFAULT_DDB_BILLING_MODE);
}
/**
* Constructor for integration tests - see comment on superclass for documentation on setting the consistentReads
* flag.

13
src/main/java/com/amazonaws/services/kinesis/leases/impl/LeaseManager.java
View file

@ -20,6 +20,7 @@ import java.util.Map;
import java.util.concurrent.TimeUnit;
import com.amazonaws.services.dynamodbv2.model.BillingMode;
import com.amazonaws.services.kinesis.clientlibrary.lib.worker.KinesisClientLibConfiguration;
import com.amazonaws.services.kinesis.leases.util.DynamoUtils;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
@ -64,6 +65,18 @@ public class LeaseManager<T extends Lease> implements ILeaseManager<T> {
protected boolean consistentReads;
private BillingMode billingMode;
/**
* Constructor.
*
* @param table leases table
* @param dynamoDBClient DynamoDB client to use
* @param serializer LeaseSerializer to use to convert to/from DynamoDB objects.
*/
@Deprecated
public LeaseManager(String table, AmazonDynamoDB dynamoDBClient, ILeaseSerializer<T> serializer) {
this(table, dynamoDBClient, serializer, false, KinesisClientLibConfiguration.DEFAULT_DDB_BILLING_MODE);
}
/**
* Constructor.
*