From b1cc74ee4ae6abc9194d5515cf025a32a23f8d49 Mon Sep 17 00:00:00 2001 From: Qilin Jin Date: Thu, 28 Apr 2022 14:30:56 -0700 Subject: [PATCH] Bug fix for cleanupLease logic -- not check child shards when cleanup is disabled --- .../services/kinesis/leases/impl/LeaseCleanupManager.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/amazonaws/services/kinesis/leases/impl/LeaseCleanupManager.java b/src/main/java/com/amazonaws/services/kinesis/leases/impl/LeaseCleanupManager.java index d19fc3ed..6d824a8a 100644 --- a/src/main/java/com/amazonaws/services/kinesis/leases/impl/LeaseCleanupManager.java +++ b/src/main/java/com/amazonaws/services/kinesis/leases/impl/LeaseCleanupManager.java @@ -238,7 +238,7 @@ public class LeaseCleanupManager { } else { cleanupFailureReason = "Configuration/Interval condition not satisfied to execute lease cleanup this cycle"; } - if (!cleanedUpCompletedLease && !alreadyCheckedForGarbageCollection && timeToCheckForGarbageShard) { + if (cleanupLeasesUponShardCompletion && !cleanedUpCompletedLease && !alreadyCheckedForGarbageCollection && timeToCheckForGarbageShard) { // throws ResourceNotFoundException wereChildShardsPresent = !CollectionUtils .isNullOrEmpty(getChildShardsFromService(shardInfo));