luciano/amazon-kinesis-client
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Making configurations consistent in entire package (#453)

Browse source
This commit is contained in:
Sahil Palvia 2018-10-25 10:40:35 -07:00 committed by GitHub
parent 9f9620354e
commit b83a32b492
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
amazon-kinesis-client/src/main/java/software/amazon/kinesis/retrieval/RetrievalConfig.java
View file

@ -88,7 +88,7 @@ public class RetrievalConfig {
if (retrievalFactory == null) {
if (retrievalSpecificConfig == null) {
retrievalSpecificConfig = new FanOutConfig(kinesisClient).streamName(streamName())
retrievalSpecificConfig = new FanOutConfig(kinesisClient()).streamName(streamName())
.applicationName(applicationName());
}
retrievalFactory = retrievalSpecificConfig.retrievalFactory();

10
amazon-kinesis-client/src/main/java/software/amazon/kinesis/retrieval/fanout/FanOutConfig.java
View file

@ -99,9 +99,9 @@ public class FanOutConfig implements RetrievalSpecificConfig {
}
private FanOutConsumerRegistration createConsumerRegistration() {
String consumerToCreate = ObjectUtils.firstNonNull(consumerName, applicationName);
return createConsumerRegistration(kinesisClient,
Preconditions.checkNotNull(streamName, "streamName must be set for consumer creation"),
String consumerToCreate = ObjectUtils.firstNonNull(consumerName(), applicationName());
return createConsumerRegistration(kinesisClient(),
Preconditions.checkNotNull(streamName(), "streamName must be set for consumer creation"),
Preconditions.checkNotNull(consumerToCreate,
"applicationName or consumerName must be set for consumer creation"));
@ -109,8 +109,8 @@ public class FanOutConfig implements RetrievalSpecificConfig {
protected FanOutConsumerRegistration createConsumerRegistration(KinesisAsyncClient client, String stream,
String consumerToCreate) {
return new FanOutConsumerRegistration(client, stream, consumerToCreate, maxDescribeStreamSummaryRetries,
maxDescribeStreamConsumerRetries, registerStreamConsumerRetries, retryBackoffMillis);
return new FanOutConsumerRegistration(client, stream, consumerToCreate, maxDescribeStreamSummaryRetries(),
maxDescribeStreamConsumerRetries(), registerStreamConsumerRetries(), retryBackoffMillis());
}
}