Logging to track pending leases to cleanup

This commit is contained in:
Ashwin Giridharan 2020-06-24 12:43:55 -07:00
parent a2b6019336
commit bd6a7d8b90

View file

@ -136,7 +136,7 @@ public class LeaseCleanupManager {
* Returns how many leases are currently waiting in the queue pending deletion. * Returns how many leases are currently waiting in the queue pending deletion.
* @return number of leases pending deletion. * @return number of leases pending deletion.
*/ */
public int leasesPendingDeletion() { private int leasesPendingDeletion() {
return deletionQueue.size(); return deletionQueue.size();
} }
@ -311,6 +311,7 @@ public class LeaseCleanupManager {
@VisibleForTesting @VisibleForTesting
void cleanupLeases() { void cleanupLeases() {
log.info("Number of pending leases to clean before the scan : {}", leasesPendingDeletion());
if (deletionQueue.isEmpty()) { if (deletionQueue.isEmpty()) {
log.debug("No leases pending deletion."); log.debug("No leases pending deletion.");
} else if (timeToCheckForCompletedShard() | timeToCheckForGarbageShard()) { } else if (timeToCheckForCompletedShard() | timeToCheckForGarbageShard()) {
@ -341,24 +342,22 @@ public class LeaseCleanupManager {
log.error("Failed to cleanup lease {} for {}. Will re-enqueue for deletion and retry on next " + log.error("Failed to cleanup lease {} for {}. Will re-enqueue for deletion and retry on next " +
"scheduled execution.", leaseKey, streamIdentifier, e); "scheduled execution.", leaseKey, streamIdentifier, e);
} }
if (!deletionSucceeded) { if (!deletionSucceeded) {
log.debug("Did not cleanup lease {} for {}. Re-enqueueing for deletion.", leaseKey, streamIdentifier); log.debug("Did not cleanup lease {} for {}. Re-enqueueing for deletion.", leaseKey, streamIdentifier);
failedDeletions.add(leasePendingDeletion); failedDeletions.add(leasePendingDeletion);
} }
} }
if (completedLeaseCleanedUp) { if (completedLeaseCleanedUp) {
log.debug("At least one completed lease was cleaned up - restarting interval"); log.debug("At least one completed lease was cleaned up - restarting interval");
completedLeaseStopwatch.reset().start(); completedLeaseStopwatch.reset().start();
} }
if (garbageLeaseCleanedUp) { if (garbageLeaseCleanedUp) {
log.debug("At least one garbage lease was cleaned up - restarting interval"); log.debug("At least one garbage lease was cleaned up - restarting interval");
garbageLeaseStopwatch.reset().start(); garbageLeaseStopwatch.reset().start();
} }
deletionQueue.addAll(failedDeletions); deletionQueue.addAll(failedDeletions);
log.info("Number of pending leases to clean after the scan : {}", leasesPendingDeletion());
} }
} }