luciano/amazon-kinesis-client
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Let healthchecks happen after initialization is complete

Browse source
This commit is contained in:
Aravinda Kidambi Srinivasan 2024-04-29 21:32:26 -07:00
parent 651bf4d28c
commit bde5ae9dac
1 changed files with 17 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
amazon-kinesis-client/src/main/java/software/amazon/kinesis/lifecycle/ShardConsumer.java
View file

@ -174,26 +174,24 @@ public class ShardConsumer {
if (isShutdownRequested()) { if (isShutdownRequested()) {
stateChangeFuture = shutdownComplete(); stateChangeFuture = shutdownComplete();
} else if (needsInitialization) { } else if (needsInitialization) {
if (stateChangeFuture != null) { if (stateChangeFuture != null && stateChangeFuture.get()) {
if (stateChangeFuture.get()) { // Task rejection during the subscribe() call will not be propagated back as it not executed
// Task rejection during the subscribe() call will not be propagated back as it not executed // in the context of the Scheduler thread. Hence we should not assume the subscription will
// in the context of the Scheduler thread. Hence we should not assume the subscription will // always be successful.
// always be successful. // But if subscription was not successful, then it will recover
// But if subscription was not successful, then it will recover // during healthCheck which will restart subscription.
// during healthCheck which will restart subscription. // From Shardconsumer point of view, initialization after the below subscribe call
// From Shardconsumer point of view, initialization after the below subscribe call // is complete
// is complete subscribe();
subscribe(); needsInitialization = false;
needsInitialization = false; // Initialization is complete, we don't need to do initializeComplete anymore.
// Initialization is complete, return now, because we dont need to do // ShardConsumer is already in ProcessingState and any further activity
// initializeComplete anymore. ShardConsumer is in ProcessingState now and any further activity // will be driven by publisher pushing data to subscriber which invokes handleInput
// will be driven by publisher pushing data to subscriber which invokes handleInput // and that triggers ProcessTask. Scheduler is only meant to do health-checks
// and that triggers ProcessTask. Scheduler is only meant to do health-checks // to ensure the consumer is not stuck for any reason and to do shutdown handling.
// to ensure the consumer is not stuck for any reason and to do shutdown handling. } else {
return; stateChangeFuture = initializeComplete();
}
} }
stateChangeFuture = initializeComplete();
} }
} catch (InterruptedException e) { } catch (InterruptedException e) {
// //