luciano/amazon-kinesis-client
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix flaky HashRangesAreAlwaysComplete test

Browse source 
Adds mechanism to allow in-progress parents to finish (marked as SHARD_END) if testFor1000DifferentValidReshardHierarchyTreeWithSomeInProgressParentsTheHashRangesAreAlwaysComplete detects hole due to merged parent shards still holding an active lease.
This commit is contained in:
furq-aws 2023-03-16 04:52:56 -07:00
parent 9ff99f0182
commit c23d83dc9a
1 changed files with 16 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
amazon-kinesis-client/src/test/java/software/amazon/kinesis/coordinator/PeriodicShardSyncManagerTest.java
View file

@ -459,7 +459,15 @@ public class PeriodicShardSyncManagerTest {
List<Lease> leases = generateInitialLeases(maxInitialLeaseCount);
reshard(leases, 5, ReshardType.ANY, maxInitialLeaseCount, true);
Collections.shuffle(leases);
Assert.assertFalse(periodicShardSyncManager.hasHoleInLeases(streamIdentifier, leases).isPresent());
boolean isHoleInHashRanges = periodicShardSyncManager.hasHoleInLeases(streamIdentifier, leases).isPresent();
if (isHoleInHashRanges) {
// In-progress parents may result in a lease having the highest startingHashKey value while not having
// an endingHashKey value of MAX_HASH_KEY. This is detected as a "hole" in the hash key range,
// so mark the in-progress parents as finished (SHARD_END) and recheck for holes.
finishInProgressParents(leases);
isHoleInHashRanges = periodicShardSyncManager.hasHoleInLeases(streamIdentifier, leases).isPresent();
}
Assert.assertFalse(isHoleInHashRanges);
}
}
@ -569,6 +577,13 @@ public class PeriodicShardSyncManagerTest {
return leaseCounter;
}
private void finishInProgressParents(List<Lease> leases) {
leases.stream()
.filter(l -> l.checkpoint() != null && !l.checkpoint().equals(ExtendedSequenceNumber.SHARD_END) &&
l.childShardIds() != null && !l.childShardIds().isEmpty())
.forEach(l -> l.checkpoint(ExtendedSequenceNumber.SHARD_END));
}
private boolean isHeads() {
return Math.random() <= 0.5;
}