luciano/amazon-kinesis-client
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Make use of Java 8 to simplify computeLeaseCounts() (#847)

Browse source 
It's possible to remove quite a few lines of code from the
method using Java 8 features (a `groupingBy` Collector, etc).

Java 8 is the minimum supported version of the KCL since
https://github.com/awslabs/amazon-kinesis-client/pull/176 was
merged in July 2017.

See also:

https://docs.oracle.com/javase/8/docs/api/java/util/stream/package-summary.html#package.description
http://cr.openjdk.java.net/~briangoetz/lambda/lambda-translation.html
This commit is contained in:
Roberto Tyley 2021-10-04 11:21:11 +01:00 committed by GitHub
parent 4fe29ff444
commit e638c1730a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
amazon-kinesis-client/src/main/java/software/amazon/kinesis/leases/dynamodb/DynamoDBLeaseTaker.java
View file

@ -40,6 +40,9 @@ import software.amazon.kinesis.metrics.MetricsLevel;
import software.amazon.kinesis.metrics.MetricsScope; import software.amazon.kinesis.metrics.MetricsScope;
import software.amazon.kinesis.metrics.MetricsUtil; import software.amazon.kinesis.metrics.MetricsUtil;
import static java.util.stream.Collectors.groupingBy;
import static java.util.stream.Collectors.summingInt;
/** /**
* An implementation of {@link LeaseTaker} that uses DynamoDB via {@link LeaseRefresher}. * An implementation of {@link LeaseTaker} that uses DynamoDB via {@link LeaseRefresher}.
*/ */
@ -539,30 +542,16 @@ public class DynamoDBLeaseTaker implements LeaseTaker {
* @return map of workerIdentifier to lease count * @return map of workerIdentifier to lease count
*/ */
private Map<String, Integer> computeLeaseCounts(List<Lease> expiredLeases) { private Map<String, Integer> computeLeaseCounts(List<Lease> expiredLeases) {
Map<String, Integer> leaseCounts = new HashMap<>();
// The set will give much faster lookup than the original list, an // The set will give much faster lookup than the original list, an
// important optimization when the list is large // important optimization when the list is large
Set<Lease> expiredLeasesSet = new HashSet<>(expiredLeases); Set<Lease> expiredLeasesSet = new HashSet<>(expiredLeases);
// Compute the number of leases per worker by looking through allLeases and ignoring leases that have expired. Map<String, Integer> leaseCounts = allLeases.values().stream()
for (Lease lease : allLeases.values()) { .filter(lease -> !expiredLeasesSet.contains(lease))
if (!expiredLeasesSet.contains(lease)) { .collect(groupingBy(Lease::leaseOwner, summingInt(lease -> 1)));
String leaseOwner = lease.leaseOwner();
Integer oldCount = leaseCounts.get(leaseOwner);
if (oldCount == null) {
leaseCounts.put(leaseOwner, 1);
} else {
leaseCounts.put(leaseOwner, oldCount + 1);
}
}
}
// If I have no leases, I wasn't represented in leaseCounts. Let's fix that. // If I have no leases, I won't be represented in leaseCounts. Let's fix that.
Integer myCount = leaseCounts.get(workerIdentifier); leaseCounts.putIfAbsent(workerIdentifier, 0);
if (myCount == null) {
myCount = 0;
leaseCounts.put(workerIdentifier, myCount);
}
return leaseCounts; return leaseCounts;
} }