luciano/amazon-kinesis-client
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Generate wrappers from proto files instead of shipping them directly (#1340)

Browse source 
* Replace generated code with source .proto files

This change replaces the generated Messages.java file with the source .proto files.
It also includes the pom.xml changes needed to install protoc from Maven Central, and use it to compile the wrapper java code.

* add explanatory comment
This commit is contained in:
nakulj 2024-06-03 15:20:07 -07:00 committed by GitHub
parent a83b3fbd57
commit e8c3c01b12
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 47 additions and 2661 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
amazon-kinesis-client/pom.xml
View file

@ -48,6 +48,7 @@
</licenses>
<properties>
<protobuf.version>3.21.12</protobuf.version>
<sqlite4java.version>1.0.392</sqlite4java.version>
<sqlite4java.native>libsqlite4java</sqlite4java.native>
<sqlite4java.libpath>${project.build.directory}/test-lib</sqlite4java.libpath>
@ -95,7 +96,7 @@
<dependency>
<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-java</artifactId>
<version>3.21.12</version>
<version>${protobuf.version}</version>
</dependency>
<dependency>
<groupId>org.apache.commons</groupId>
@ -180,6 +181,13 @@
</developers>
<build>
<extensions>
<extension>
<groupId>kr.motd.maven</groupId>
<artifactId>os-maven-plugin</artifactId>
<version>1.6.0</version>
</extension>
</extensions>
<pluginManagement>
<plugins>
<plugin>
@ -195,6 +203,21 @@
</pluginManagement>
<plugins>
<plugin>
<groupId>org.xolstice.maven.plugins</groupId>
<artifactId>protobuf-maven-plugin</artifactId>
<version>0.6.1</version>
<executions>
<execution>
<goals>
<goal>compile</goal>
</goals>
</execution>
</executions>
<configuration>
<protocArtifact>com.google.protobuf:protoc:${protobuf.version}:exe:${os.detected.classifier}</protocArtifact>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>

2660
amazon-kinesis-client/src/main/java/software/amazon/kinesis/retrieval/kpl/Messages.java
View file

File diff suppressed because it is too large Load diff

23
amazon-kinesis-client/src/main/proto/messages.proto Normal file
View file

@ -0,0 +1,23 @@
// Copied from amazon-kinesis-producer/aws/kinesis/protobuf/messages.proto with
// subset of messages that KCL needs
syntax = "proto2";
package software.amazon.kinesis.retrieval.kpl;
message Tag {
required string key = 1;
optional string value = 2;
}
message Record {
required uint64 partition_key_index = 1;
optional uint64 explicit_hash_key_index = 2;
required bytes data = 3;
repeated Tag tags = 4;
}
message AggregatedRecord {
repeated string partition_key_table = 1;
repeated string explicit_hash_key_table = 2;
repeated Record records = 3;
}