From ee54e30b847e32710559364b2da4b8607f9a9cbc Mon Sep 17 00:00:00 2001 From: Mike Watters Date: Tue, 12 Dec 2017 13:16:01 -0700 Subject: [PATCH] use `StringUtils.join` instead of manually building ids string --- .../kinesis/clientlibrary/lib/worker/ShardSyncer.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/main/java/com/amazonaws/services/kinesis/clientlibrary/lib/worker/ShardSyncer.java b/src/main/java/com/amazonaws/services/kinesis/clientlibrary/lib/worker/ShardSyncer.java index 5cb7d6a8..2e309156 100644 --- a/src/main/java/com/amazonaws/services/kinesis/clientlibrary/lib/worker/ShardSyncer.java +++ b/src/main/java/com/amazonaws/services/kinesis/clientlibrary/lib/worker/ShardSyncer.java @@ -28,6 +28,7 @@ import java.util.Set; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; +import org.apache.commons.lang.StringUtils; import com.amazonaws.services.kinesis.clientlibrary.exceptions.internal.KinesisClientLibIOException; import com.amazonaws.services.kinesis.clientlibrary.proxies.IKinesisProxy; @@ -167,10 +168,7 @@ class ShardSyncer { private static void assertAllParentShardsAreClosed(Set inconsistentShardIds) throws KinesisClientLibIOException { if (!inconsistentShardIds.isEmpty()) { - String ids = ""; - for (String id : inconsistentShardIds) { - ids += " " + id; - } + String ids = StringUtils.join(inconsistentShardIds, ' '); throw new KinesisClientLibIOException(String.format("%d open child shards (%s) are inconsistent. " + "This can happen due to a race condition between describeStream and a reshard operation.", inconsistentShardIds.size(), ids));