luciano/amazon-kinesis-client
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Suppress LeaseAssignmentManager excessive WARN logs when there is no issue

Browse source 
This commit fixes https://github.com/awslabs/amazon-kinesis-client/issues/1407. The WARN level log statements should only be executed when a real problem had been detected.
This commit is contained in:
ivanlkc 2025-02-06 16:12:19 -05:00 committed by GitHub
parent ae9a433ebd
commit f1769ecd80
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
amazon-kinesis-client/src/main/java/software/amazon/kinesis/coordinator/assignment/LeaseAssignmentManager.java
View file

@ -537,8 +537,8 @@ public final class LeaseAssignmentManager {
.filter(workerMetrics -> !workerMetrics.isValidWorkerMetric()) .filter(workerMetrics -> !workerMetrics.isValidWorkerMetric())
.map(WorkerMetricStats::getWorkerId) .map(WorkerMetricStats::getWorkerId)
.collect(Collectors.toList()); .collect(Collectors.toList());
log.warn("List of workerIds with invalid entries : {}", listOfWorkerIdOfInvalidWorkerMetricsEntry);
if (!listOfWorkerIdOfInvalidWorkerMetricsEntry.isEmpty()) { if (!listOfWorkerIdOfInvalidWorkerMetricsEntry.isEmpty()) {
log.warn("List of workerIds with invalid entries : {}", listOfWorkerIdOfInvalidWorkerMetricsEntry);
metricsScope.addData( metricsScope.addData(
"NumWorkersWithInvalidEntry", "NumWorkersWithInvalidEntry",
listOfWorkerIdOfInvalidWorkerMetricsEntry.size(), listOfWorkerIdOfInvalidWorkerMetricsEntry.size(),
@ -567,8 +567,8 @@ public final class LeaseAssignmentManager {
final Map.Entry<List<Lease>, List<String>> leaseListResponse = leaseListFuture.join(); final Map.Entry<List<Lease>, List<String>> leaseListResponse = leaseListFuture.join();
this.leaseList = leaseListResponse.getKey(); this.leaseList = leaseListResponse.getKey();
log.warn("Leases that failed deserialization : {}", leaseListResponse.getValue());
if (!leaseListResponse.getValue().isEmpty()) { if (!leaseListResponse.getValue().isEmpty()) {
log.warn("Leases that failed deserialization : {}", leaseListResponse.getValue());
MetricsUtil.addCount( MetricsUtil.addCount(
metricsScope, metricsScope,
"LeaseDeserializationFailureCount", "LeaseDeserializationFailureCount",