Review comments

This commit is contained in:
Noah Bogart 2024-05-13 11:58:45 -04:00
parent 59cd6a829a
commit 143d2f1326
2 changed files with 4 additions and 14 deletions

View file

@ -7,7 +7,7 @@
(def omap-ns (sci/create-ns 'flatland.ordered.map nil)) (def omap-ns (sci/create-ns 'flatland.ordered.map nil))
(def oset-ns (sci/create-ns 'flatland.ordered.set nil)) (def oset-ns (sci/create-ns 'flatland.ordered.set nil))
(def ordered-ns (def ordered-map-ns
{'ordered-map (sci/copy-var omap/ordered-map omap-ns)}) {'ordered-map (sci/copy-var omap/ordered-map omap-ns)})
(def ordered-set-ns (def ordered-set-ns

View file

@ -50,8 +50,7 @@
(do (write {"format" (if (= format :json) (do (write {"format" (if (= format :json)
"json" "json"
"edn") "edn")
"readers" {"ordered/map" "flatland.ordered.map/ordered-map" "readers" {"ordered/map" "flatland.ordered.map/ordered-map"}
"ordered/set" "flatland.ordered.set/ordered-set"}
"namespaces" "namespaces"
[{"name" "pod.test-pod" [{"name" "pod.test-pod"
"vars" [{"name" "add-sync"} "vars" [{"name" "add-sync"}
@ -65,8 +64,7 @@
{"name" "error"} {"name" "error"}
{"name" "print"} {"name" "print"}
{"name" "print-err"} {"name" "print-err"}
{"name" "ordered-map"} {"name" "ordered-map"}]}]
{"name" "ordered-set"}]}]
"ops" {"shutdown" {}}}) "ops" {"shutdown" {}}})
(recur)) (recur))
:invoke (let [var (-> (get message "var") :invoke (let [var (-> (get message "var")
@ -121,11 +119,6 @@
pod.test-pod/ordered-map pod.test-pod/ordered-map
(write (write
{"value" "#ordered/map([:a 1] [:b 2])" {"value" "#ordered/map([:a 1] [:b 2])"
"status" ["done"]
"id" id})
pod.test-pod/ordered-set
(write
{"value" "#ordered/set([:a 1 :b 2])"
"status" ["done"] "status" ["done"]
"id" id})) "id" id}))
(recur)) (recur))
@ -166,7 +159,4 @@
(debug "Running reader test") (debug "Running reader test")
(require '[flatland.ordered.map :refer [ordered-map]]) (require '[flatland.ordered.map :refer [ordered-map]])
(prn (= ((resolve 'flatland.ordered.map/ordered-map) :a 1 :b 2) (prn (= ((resolve 'flatland.ordered.map/ordered-map) :a 1 :b 2)
((resolve 'pod.test-pod/ordered-map)))) ((resolve 'pod.test-pod/ordered-map)))))))))
(require '[flatland.ordered.set :refer [ordered-set]])
(prn (= ((resolve 'flatland.ordered.set/ordered-set) :a 1 :b 2)
((resolve 'pod.test-pod/ordered-set)))))))))