luciano/babashka
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Confirm fix for#1639 by adding test

Browse source
This commit is contained in:
Michiel Borkent 2023-11-02 13:30:38 +01:00
parent 6b52831a21
commit 2e23471612
2 changed files with 22 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
CHANGELOG.md
View file

@ -12,13 +12,14 @@ A preview of the next release can be installed from
- [Support self-contained binaries as uberjars!](https://github.com/babashka/babashka/wiki/Self-contained-executable#uberjar) - [Support self-contained binaries as uberjars!](https://github.com/babashka/babashka/wiki/Self-contained-executable#uberjar)
- Add `java.security.KeyFactory`, `java.security.spec.PKCS8EncodedKeySpec`, `java.net.URISyntaxException` - Add `java.security.KeyFactory`, `java.security.spec.PKCS8EncodedKeySpec`, `java.net.URISyntaxException`
- Fix babashka.process/exec wrt `babashka.process/*defaults*` - Fix babashka.process/exec wrt `babashka.process/*defaults*`
- #1632: Partial fix for `(.readPassword (System/console))` - [#1632](https://github.com/babashka/babashka/issues/1632): Partial fix for `(.readPassword (System/console))`
- Enable producing self-contained binaries using [uberjars](https://github.com/babashka/babashka/wiki/Self-contained-executable#uberjar) - Enable producing self-contained binaries using [uberjars](https://github.com/babashka/babashka/wiki/Self-contained-executable#uberjar)
- Bump httpkit to `2.8.0-beta3` (fixes GraalVM issue with virtual threads) - Bump httpkit to `2.8.0-beta3` (fixes GraalVM issue with virtual threads)
- Bump `deps.clj` and `fs` - Bump `deps.clj` and `fs`
- Expose `taoensso.timbre.appenders.core` - Expose `taoensso.timbre.appenders.core`
- nREPL: implement `ns-list` op - nREPL: implement `ns-list` op
- SCI: optimize `swap!`, `deref` and `reset!` for normal atoms (rather than user-created `IAtom`s) - SCI: optimize `swap!`, `deref` and `reset!` for normal atoms (rather than user-created `IAtom`s)
- Add test for [#1639](https://github.com/babashka/babashka/issues/1639)
## 1.3.185 (2023-09-28) ## 1.3.185 (2023-09-28)

21
test/babashka/xml_test.clj
View file

@ -1,7 +1,7 @@
(ns babashka.xml-test (ns babashka.xml-test
(:require [babashka.test-utils :as test-utils] (:require [babashka.test-utils :as test-utils]
[clojure.string :as str] [clojure.string :as str]
[clojure.test :refer [deftest is testing]])) [clojure.test :refer [deftest is]]))
(def simple-xml-str "<a><b>data</b></a>") (def simple-xml-str "<a><b>data</b></a>")
@ -15,3 +15,22 @@
(deftest xml-data-readers-test (deftest xml-data-readers-test
(is (str/includes? (test-utils/bb nil round-trip-prog) simple-xml-str))) (is (str/includes? (test-utils/bb nil round-trip-prog) simple-xml-str)))
(deftest virtual-threads-bug-test
(is (str/starts-with? (test-utils/bb nil "(require '[clojure.core.async]
'[clojure.data.xml])
(def go-blocks (atom []))
(dotimes [_ 100]
(swap! go-blocks conj (clojure.core.async/go (clojure.data.xml/parse
(java.io.ByteArrayInputStream.
(.getBytes \"<a></a>\" \"UTF-8\"))
:namespace-aware false
:skip-whitespace true))))
(doseq [block @go-blocks]
(clojure.core.async/<!! block))
true")
"true")))