luciano/bandalore
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Minimize Integer object construction

Browse source 
Use Integer.valueOf(int) factory method instead of new Integer(int) constructor
to take advantage of caching.
This is especially useful when creating millions of
ReceiveMessageRequests with the same options.
This commit is contained in:
Daniel Alberto Cañas 2014-06-24 21:48:33 -06:00
parent ce8c02bdc4
commit daffed7bcc
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/main/clojure/cemerick/bandalore.clj
View file

@ -128,10 +128,10 @@
:or {limit 1 :or {limit 1
attributes #{}}}] attributes #{}}}]
(let [req (-> (ReceiveMessageRequest. queue-url) (let [req (-> (ReceiveMessageRequest. queue-url)
(.withMaxNumberOfMessages (-> limit (min 10) (max 1) int Integer.)) (.withMaxNumberOfMessages (-> limit (min 10) (max 1) int Integer/valueOf))
(.withAttributeNames attributes)) (.withAttributeNames attributes))
req (if wait-time-seconds (.withWaitTimeSeconds req (Integer. (int wait-time-seconds))) req) req (if wait-time-seconds (.withWaitTimeSeconds req (Integer/valueOf (int wait-time-seconds))) req)
req (if visibility (.withVisibilityTimeout req (Integer. (int visibility))) req)] req (if visibility (.withVisibilityTimeout req (Integer/valueOf (int visibility))) req)]
(->> (.receiveMessage client req) (->> (.receiveMessage client req)
.getMessages .getMessages
(map (partial message-map queue-url))))) (map (partial message-map queue-url)))))