From 807e32abbb2599c3848eb719e87db47fcfe9efc4 Mon Sep 17 00:00:00 2001 From: Kenneth Kostresevic Date: Fri, 17 Dec 2021 13:03:37 +0100 Subject: [PATCH] Avoid extra decrementation in factorial --- src/koans/14_recursion.clj | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/koans/14_recursion.clj b/src/koans/14_recursion.clj index 5e05015..81abc0c 100644 --- a/src/koans/14_recursion.clj +++ b/src/koans/14_recursion.clj @@ -20,10 +20,10 @@ (recur tail (conj new-coll head))))) (defn factorial [n] - (loop [n n acc n] + (loop [n n acc 1] (if (= n 1) acc - (recur (dec n) (* acc (dec n)))))) + (recur (dec n) (* acc n))))) (meditations "Recursion ends with a base case"