luciano/coffi
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

remove performance comments on things already split out

Browse source
This commit is contained in:
Joshua Suskalo 2021-10-10 12:11:14 -05:00
parent 80beace196
commit c43ff5a848
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/clj/coffi/mem.clj
View file

@ -428,7 +428,6 @@
[obj type segment scope] [obj type segment scope]
(type-dispatch type))) (type-dispatch type)))
;; TODO(Joshua): For performance, turn this into a bunch of specific defmethods
(defmethod serialize-into :default (defmethod serialize-into :default
[obj type segment scope] [obj type segment scope]
(if-some [prim-layout (primitive-type type)] (if-some [prim-layout (primitive-type type)]
@ -507,14 +506,12 @@
[segment type] [segment type]
(type-dispatch type))) (type-dispatch type)))
;; TODO(Joshua): For performance, turn this into a bunch of specific defmethods
(defmethod deserialize-from :default (defmethod deserialize-from :default
[segment type] [segment type]
(if-some [prim (primitive-type type)] (if-some [prim (primitive-type type)]
(with-acquired [(segment-scope segment)]
(-> segment (-> segment
(deserialize-from prim) (deserialize-from prim)
(deserialize* type))) (deserialize* type))
(throw (ex-info "Attempted to deserialize a non-primitive type that has not been overriden" (throw (ex-info "Attempted to deserialize a non-primitive type that has not been overriden"
{:type type {:type type
:segment segment})))) :segment segment}))))