From 0b614b79b3c4f5cee9314001a0c256eeb7db2593 Mon Sep 17 00:00:00 2001 From: Alexander Wang Date: Sun, 4 Dec 2022 22:37:42 -0800 Subject: [PATCH] no aspect ratio actor height --- d2layouts/d2sequence/sequence_diagram.go | 2 - .../dagre/board.exp.json | 32 +- .../dagre/sketch.exp.svg | 4 +- .../elk/board.exp.json | 32 +- .../elk/sketch.exp.svg | 4 +- .../dagre/board.exp.json | 90 ++-- .../dagre/sketch.exp.svg | 14 +- .../elk/board.exp.json | 90 ++-- .../elk/sketch.exp.svg | 14 +- .../dagre/board.exp.json | 108 ++--- .../dagre/sketch.exp.svg | 4 +- .../elk/board.exp.json | 108 ++--- .../elk/sketch.exp.svg | 4 +- .../dagre/board.exp.json | 50 +-- .../dagre/sketch.exp.svg | 8 +- .../sequence_diagram_note/elk/board.exp.json | 50 +-- .../sequence_diagram_note/elk/sketch.exp.svg | 8 +- .../dagre/board.exp.json | 114 ++--- .../dagre/sketch.exp.svg | 32 +- .../sequence_diagram_real/elk/board.exp.json | 118 +++--- .../sequence_diagram_real/elk/sketch.exp.svg | 32 +- .../dagre/board.exp.json | 68 +-- .../dagre/sketch.exp.svg | 18 +- .../elk/board.exp.json | 68 +-- .../elk/sketch.exp.svg | 18 +- .../dagre/board.exp.json | 12 +- .../dagre/sketch.exp.svg | 2 +- .../elk/board.exp.json | 12 +- .../elk/sketch.exp.svg | 2 +- .../dagre/board.exp.json | 112 ++--- .../dagre/sketch.exp.svg | 30 +- .../sequence_diagram_span/elk/board.exp.json | 112 ++--- .../sequence_diagram_span/elk/sketch.exp.svg | 30 +- .../sequence_diagrams/dagre/board.exp.json | 394 +++++++++--------- .../sequence_diagrams/dagre/sketch.exp.svg | 54 +-- .../sequence_diagrams/elk/board.exp.json | 360 ++++++++-------- .../sequence_diagrams/elk/sketch.exp.svg | 54 +-- 37 files changed, 1131 insertions(+), 1133 deletions(-) diff --git a/d2layouts/d2sequence/sequence_diagram.go b/d2layouts/d2sequence/sequence_diagram.go index a6a704cc2..0876d8568 100644 --- a/d2layouts/d2sequence/sequence_diagram.go +++ b/d2layouts/d2sequence/sequence_diagram.go @@ -101,9 +101,7 @@ func newSequenceDiagram(objects []*d2graph.Object, messages []*d2graph.Edge) *se sd.objectRank[actor] = rank if actor.Width < MIN_ACTOR_WIDTH { - aspectRatio := actor.Height / actor.Width actor.Width = MIN_ACTOR_WIDTH - actor.Height = math.Round(aspectRatio * actor.Width) } sd.maxActorHeight = math.Max(sd.maxActorHeight, actor.Height) diff --git a/e2etests/testdata/stable/sequence_diagram_all_shapes/dagre/board.exp.json b/e2etests/testdata/stable/sequence_diagram_all_shapes/dagre/board.exp.json index f06d31ed2..73b2fad99 100644 --- a/e2etests/testdata/stable/sequence_diagram_all_shapes/dagre/board.exp.json +++ b/e2etests/testdata/stable/sequence_diagram_all_shapes/dagre/board.exp.json @@ -45,10 +45,10 @@ "type": "oval", "pos": { "x": 223, - "y": 84 + "y": 87 }, "width": 150, - "height": 150, + "height": 147, "opacity": 1, "strokeDash": 0, "strokeWidth": 2, @@ -212,10 +212,10 @@ "type": "cylinder", "pos": { "x": 1269, - "y": 84 + "y": 108 }, "width": 150, - "height": 150, + "height": 126, "opacity": 1, "strokeDash": 0, "strokeWidth": 2, @@ -251,10 +251,10 @@ "type": "diamond", "pos": { "x": 1489, - "y": 85 + "y": 108 }, "width": 150, - "height": 149, + "height": 126, "opacity": 1, "strokeDash": 0, "strokeWidth": 2, @@ -290,10 +290,10 @@ "type": "document", "pos": { "x": 1709, - "y": 97 + "y": 108 }, "width": 150, - "height": 137, + "height": 126, "opacity": 1, "strokeDash": 0, "strokeWidth": 2, @@ -368,10 +368,10 @@ "type": "image", "pos": { "x": 2181, - "y": 63 + "y": 85 }, "width": 150, - "height": 150, + "height": 128, "opacity": 1, "strokeDash": 0, "strokeWidth": 2, @@ -418,10 +418,10 @@ "type": "oval", "pos": { "x": 2401, - "y": 97 + "y": 108 }, "width": 150, - "height": 137, + "height": 126, "opacity": 1, "strokeDash": 0, "strokeWidth": 2, @@ -457,10 +457,10 @@ "type": "package", "pos": { "x": 2621, - "y": 98 + "y": 108 }, "width": 150, - "height": 136, + "height": 126, "opacity": 1, "strokeDash": 0, "strokeWidth": 2, @@ -730,10 +730,10 @@ "type": "stored_data", "pos": { "x": 4312, - "y": 96 + "y": 108 }, "width": 150, - "height": 138, + "height": 126, "opacity": 1, "strokeDash": 0, "strokeWidth": 2, diff --git a/e2etests/testdata/stable/sequence_diagram_all_shapes/dagre/sketch.exp.svg b/e2etests/testdata/stable/sequence_diagram_all_shapes/dagre/sketch.exp.svg index 8cf3cf52b..7e13b2b3a 100644 --- a/e2etests/testdata/stable/sequence_diagram_all_shapes/dagre/sketch.exp.svg +++ b/e2etests/testdata/stable/sequence_diagram_all_shapes/dagre/sketch.exp.svg @@ -14,13 +14,13 @@ width="4942" height="2984" viewBox="-100 -50 4942 2984">a labelblabelsa class+ +a labelblabelsa class+ public() bool void- private() int voidcloudyyyya := 5 b := a + 7 -fmt.Printf("%d", b)cyldiadocssix cornersa random iconoverpackdocs pagetoohard o saysinglepersona queuea squarea step at a timedatausersid +fmt.Printf("%d", b)cyldiadocssix cornersa random iconoverpackdocs pagetoohard o saysinglepersona queuea squarea step at a timedatausersid int name varchar diff --git a/e2etests/testdata/stable/sequence_diagram_all_shapes/elk/board.exp.json b/e2etests/testdata/stable/sequence_diagram_all_shapes/elk/board.exp.json index f06d31ed2..73b2fad99 100644 --- a/e2etests/testdata/stable/sequence_diagram_all_shapes/elk/board.exp.json +++ b/e2etests/testdata/stable/sequence_diagram_all_shapes/elk/board.exp.json @@ -45,10 +45,10 @@ "type": "oval", "pos": { "x": 223, - "y": 84 + "y": 87 }, "width": 150, - "height": 150, + "height": 147, "opacity": 1, "strokeDash": 0, "strokeWidth": 2, @@ -212,10 +212,10 @@ "type": "cylinder", "pos": { "x": 1269, - "y": 84 + "y": 108 }, "width": 150, - "height": 150, + "height": 126, "opacity": 1, "strokeDash": 0, "strokeWidth": 2, @@ -251,10 +251,10 @@ "type": "diamond", "pos": { "x": 1489, - "y": 85 + "y": 108 }, "width": 150, - "height": 149, + "height": 126, "opacity": 1, "strokeDash": 0, "strokeWidth": 2, @@ -290,10 +290,10 @@ "type": "document", "pos": { "x": 1709, - "y": 97 + "y": 108 }, "width": 150, - "height": 137, + "height": 126, "opacity": 1, "strokeDash": 0, "strokeWidth": 2, @@ -368,10 +368,10 @@ "type": "image", "pos": { "x": 2181, - "y": 63 + "y": 85 }, "width": 150, - "height": 150, + "height": 128, "opacity": 1, "strokeDash": 0, "strokeWidth": 2, @@ -418,10 +418,10 @@ "type": "oval", "pos": { "x": 2401, - "y": 97 + "y": 108 }, "width": 150, - "height": 137, + "height": 126, "opacity": 1, "strokeDash": 0, "strokeWidth": 2, @@ -457,10 +457,10 @@ "type": "package", "pos": { "x": 2621, - "y": 98 + "y": 108 }, "width": 150, - "height": 136, + "height": 126, "opacity": 1, "strokeDash": 0, "strokeWidth": 2, @@ -730,10 +730,10 @@ "type": "stored_data", "pos": { "x": 4312, - "y": 96 + "y": 108 }, "width": 150, - "height": 138, + "height": 126, "opacity": 1, "strokeDash": 0, "strokeWidth": 2, diff --git a/e2etests/testdata/stable/sequence_diagram_all_shapes/elk/sketch.exp.svg b/e2etests/testdata/stable/sequence_diagram_all_shapes/elk/sketch.exp.svg index 8cf3cf52b..7e13b2b3a 100644 --- a/e2etests/testdata/stable/sequence_diagram_all_shapes/elk/sketch.exp.svg +++ b/e2etests/testdata/stable/sequence_diagram_all_shapes/elk/sketch.exp.svg @@ -14,13 +14,13 @@ width="4942" height="2984" viewBox="-100 -50 4942 2984">a labelblabelsa class+ +a labelblabelsa class+ public() bool void- private() int voidcloudyyyya := 5 b := a + 7 -fmt.Printf("%d", b)cyldiadocssix cornersa random iconoverpackdocs pagetoohard o saysinglepersona queuea squarea step at a timedatausersid +fmt.Printf("%d", b)cyldiadocssix cornersa random iconoverpackdocs pagetoohard o saysinglepersona queuea squarea step at a timedatausersid int name varchar diff --git a/e2etests/testdata/stable/sequence_diagram_groups/dagre/board.exp.json b/e2etests/testdata/stable/sequence_diagram_groups/dagre/board.exp.json index 9a6740045..251a8aed9 100644 --- a/e2etests/testdata/stable/sequence_diagram_groups/dagre/board.exp.json +++ b/e2etests/testdata/stable/sequence_diagram_groups/dagre/board.exp.json @@ -6,10 +6,10 @@ "type": "", "pos": { "x": 0, - "y": 52 + "y": 50 }, "width": 150, - "height": 167, + "height": 126, "opacity": 1, "strokeDash": 0, "strokeWidth": 2, @@ -45,10 +45,10 @@ "type": "", "pos": { "x": 220, - "y": 52 + "y": 50 }, "width": 150, - "height": 167, + "height": 126, "opacity": 1, "strokeDash": 0, "strokeWidth": 2, @@ -87,7 +87,7 @@ "y": 50 }, "width": 150, - "height": 169, + "height": 126, "opacity": 1, "strokeDash": 0, "strokeWidth": 2, @@ -123,10 +123,10 @@ "type": "", "pos": { "x": 660, - "y": 52 + "y": 50 }, "width": 150, - "height": 167, + "height": 126, "opacity": 1, "strokeDash": 0, "strokeWidth": 2, @@ -162,7 +162,7 @@ "type": "", "pos": { "x": 25, - "y": 439 + "y": 396 }, "width": 320, "height": 80, @@ -200,7 +200,7 @@ "type": "", "pos": { "x": 245, - "y": 569 + "y": 526 }, "width": 320, "height": 730, @@ -238,7 +238,7 @@ "type": "", "pos": { "x": 245, - "y": 829 + "y": 786 }, "width": 320, "height": 80, @@ -276,7 +276,7 @@ "type": "", "pos": { "x": 245, - "y": 1349 + "y": 1306 }, "width": 453, "height": 466, @@ -314,7 +314,7 @@ "type": "rectangle", "pos": { "x": 382, - "y": 1519 + "y": 1476 }, "width": 266, "height": 126, @@ -353,7 +353,7 @@ "type": "", "pos": { "x": 601, - "y": 1865 + "y": 1822 }, "width": 268, "height": 206, @@ -391,7 +391,7 @@ "type": "rectangle", "pos": { "x": 651, - "y": 1905 + "y": 1862 }, "width": 168, "height": 126, @@ -430,7 +430,7 @@ "type": "rectangle", "pos": { "x": 289, - "y": 983 + "y": 940 }, "width": 12, "height": 292, @@ -468,7 +468,7 @@ "type": "rectangle", "pos": { "x": 509, - "y": 983 + "y": 940 }, "width": 12, "height": 292, @@ -506,7 +506,7 @@ "type": "rectangle", "pos": { "x": 285, - "y": 1113 + "y": 1070 }, "width": 20, "height": 80, @@ -568,11 +568,11 @@ "route": [ { "x": 75, - "y": 349 + "y": 306 }, { "x": 295, - "y": 349 + "y": 306 } ], "animated": false, @@ -607,11 +607,11 @@ "route": [ { "x": 75, - "y": 479 + "y": 436 }, { "x": 295, - "y": 479 + "y": 436 } ], "animated": false, @@ -646,11 +646,11 @@ "route": [ { "x": 295, - "y": 609 + "y": 566 }, { "x": 515, - "y": 609 + "y": 566 } ], "animated": false, @@ -685,11 +685,11 @@ "route": [ { "x": 515, - "y": 739 + "y": 696 }, { "x": 295, - "y": 739 + "y": 696 } ], "animated": false, @@ -724,11 +724,11 @@ "route": [ { "x": 515, - "y": 869 + "y": 826 }, { "x": 295, - "y": 869 + "y": 826 } ], "animated": false, @@ -763,11 +763,11 @@ "route": [ { "x": 301, - "y": 999 + "y": 956 }, { "x": 509, - "y": 999 + "y": 956 } ], "animated": false, @@ -802,11 +802,11 @@ "route": [ { "x": 305, - "y": 1129 + "y": 1086 }, { "x": 509, - "y": 1129 + "y": 1086 } ], "animated": false, @@ -841,11 +841,11 @@ "route": [ { "x": 509, - "y": 1259 + "y": 1216 }, { "x": 301, - "y": 1259 + "y": 1216 } ], "animated": false, @@ -880,11 +880,11 @@ "route": [ { "x": 295, - "y": 1389 + "y": 1346 }, { "x": 515, - "y": 1389 + "y": 1346 } ], "animated": false, @@ -919,11 +919,11 @@ "route": [ { "x": 515, - "y": 1775 + "y": 1732 }, { "x": 295, - "y": 1775 + "y": 1732 } ], "animated": false, @@ -958,11 +958,11 @@ "route": [ { "x": 75, - "y": 219 + "y": 176 }, { "x": 75, - "y": 2161 + "y": 2118 } ], "animated": false, @@ -997,11 +997,11 @@ "route": [ { "x": 295, - "y": 219 + "y": 176 }, { "x": 295, - "y": 2161 + "y": 2118 } ], "animated": false, @@ -1036,11 +1036,11 @@ "route": [ { "x": 515, - "y": 219 + "y": 176 }, { "x": 515, - "y": 2161 + "y": 2118 } ], "animated": false, @@ -1075,11 +1075,11 @@ "route": [ { "x": 735, - "y": 219 + "y": 176 }, { "x": 735, - "y": 2161 + "y": 2118 } ], "animated": false, diff --git a/e2etests/testdata/stable/sequence_diagram_groups/dagre/sketch.exp.svg b/e2etests/testdata/stable/sequence_diagram_groups/dagre/sketch.exp.svg index b569a7a6e..507bae4f8 100644 --- a/e2etests/testdata/stable/sequence_diagram_groups/dagre/sketch.exp.svg +++ b/e2etests/testdata/stable/sequence_diagram_groups/dagre/sketch.exp.svg @@ -2,7 +2,7 @@ abcdggggroup 1group bchoonested guy lalaeyokayokaywhat would arnold saythis note + + + + + abcdggggroup 1group bchoonested guy lalaeyokayokaywhat would arnold saythis note - - - - - +abcdggggroup 1group bchoonested guy lalaeyokayokaywhat would arnold saythis note + + + + + scoreritemResponseitemessayRubricconceptitemOutcome scoreritemResponseitemessayRubricconceptitemOutcome abcd okayexplanationanother explanationSome one who believes imaginary things appear right before your i's.The earth is like a tiny grain of sand, only much, much heavier - - +abcd okayexplanationanother explanationSome one who believes imaginary things appear right before your i's.The earth is like a tiny grain of sand, only much, much heavier + + abcd okayexplanationanother explanationSome one who believes imaginary things appear right before your i's.The earth is like a tiny grain of sand, only much, much heavier - - +abcd okayexplanationanother explanationSome one who believes imaginary things appear right before your i's.The earth is like a tiny grain of sand, only much, much heavier + + How this is renderedCLId2astd2compilerd2layoutd2exporterd2themesd2rendererd2sequencelayoutd2dagrelayoutonly if root is not sequence 'How this is rendered: {...}'tokenized ASTcompile ASTobjects and edgesrun layout enginesrun engine on shape: sequence_diagram, temporarily removerun core engine on rest add back in sequence diagramsdiagram with correct positions and dimensionsexport diagram with chosen theme and rendererget theme stylesrender to SVGresulting SVGmeasurements also take place - - - - - - - - - - - - - - +How this is renderedCLId2astd2compilerd2layoutd2exporterd2themesd2rendererd2sequencelayoutd2dagrelayoutonly if root is not sequence 'How this is rendered: {...}'tokenized ASTcompile ASTobjects and edgesrun layout enginesrun engine on shape: sequence_diagram, temporarily removerun core engine on rest add back in sequence diagramsdiagram with correct positions and dimensionsexport diagram with chosen theme and rendererget theme stylesrender to SVGresulting SVGmeasurements also take place + + + + + + + + + + + + + + How this is renderedCLId2astd2compilerd2layoutd2exporterd2themesd2rendererd2sequencelayoutd2dagrelayoutonly if root is not sequence 'How this is rendered: {...}'tokenized ASTcompile ASTobjects and edgesrun layout enginesrun engine on shape: sequence_diagram, temporarily removerun core engine on rest add back in sequence diagramsdiagram with correct positions and dimensionsexport diagram with chosen theme and rendererget theme stylesrender to SVGresulting SVGmeasurements also take place - - - - - - - - - - - - - - +How this is renderedCLId2astd2compilerd2layoutd2exporterd2themesd2rendererd2sequencelayoutd2dagrelayoutonly if root is not sequence 'How this is rendered: {...}'tokenized ASTcompile ASTobjects and edgesrun layout enginesrun engine on shape: sequence_diagram, temporarily removerun core engine on rest add back in sequence diagramsdiagram with correct positions and dimensionsexport diagram with chosen theme and rendererget theme stylesrender to SVGresulting SVGmeasurements also take place + + + + + + + + + + + + + + ab a self edge herebetween actorsto descendantto deeper descendantto parentactor - - - - - - - +ab a self edge herebetween actorsto descendantto deeper descendantto parentactor + + + + + + + ab a self edge herebetween actorsto descendantto deeper descendantto parentactor - - - - - - - +ab a self edge herebetween actorsto descendantto deeper descendantto parentactor + + + + + + + AlicelinebreakerBobdbqueueanoddservicewithanameinmultiple lines Authentication Requestmake request for something that is quite far away and requires a really long label to take all the space between the objectsvalidate credentialsAuthentication ResponseAnother authentication Requestdo it later storedAnother authentication Response +AlicelinebreakerBobdbqueueanoddservicewithanameinmultiple lines Authentication Requestmake request for something that is quite far away and requires a really long label to take all the space between the objectsvalidate credentialsAuthentication ResponseAnother authentication Requestdo it later storedAnother authentication Response diff --git a/e2etests/testdata/stable/sequence_diagram_simple/elk/board.exp.json b/e2etests/testdata/stable/sequence_diagram_simple/elk/board.exp.json index a444d77d8..185e1d749 100644 --- a/e2etests/testdata/stable/sequence_diagram_simple/elk/board.exp.json +++ b/e2etests/testdata/stable/sequence_diagram_simple/elk/board.exp.json @@ -45,10 +45,10 @@ "type": "person", "pos": { "x": 233, - "y": 124 + "y": 141 }, "width": 150, - "height": 143, + "height": 126, "opacity": 1, "strokeDash": 0, "strokeWidth": 5, @@ -84,10 +84,10 @@ "type": "cylinder", "pos": { "x": 453, - "y": 136 + "y": 162 }, "width": 150, - "height": 152, + "height": 126, "opacity": 1, "strokeDash": 0, "strokeWidth": 2, @@ -123,10 +123,10 @@ "type": "queue", "pos": { "x": 673, - "y": 161 + "y": 162 }, "width": 150, - "height": 127, + "height": 126, "opacity": 1, "strokeDash": 0, "strokeWidth": 2, diff --git a/e2etests/testdata/stable/sequence_diagram_simple/elk/sketch.exp.svg b/e2etests/testdata/stable/sequence_diagram_simple/elk/sketch.exp.svg index 2d06dbcbd..4385b15c0 100644 --- a/e2etests/testdata/stable/sequence_diagram_simple/elk/sketch.exp.svg +++ b/e2etests/testdata/stable/sequence_diagram_simple/elk/sketch.exp.svg @@ -14,7 +14,7 @@ width="1295" height="1868" viewBox="-100 -50 1295 1868">AlicelinebreakerBobdbqueueanoddservicewithanameinmultiple lines Authentication Requestmake request for something that is quite far away and requires a really long label to take all the space between the objectsvalidate credentialsAuthentication ResponseAnother authentication Requestdo it later storedAnother authentication Response +AlicelinebreakerBobdbqueueanoddservicewithanameinmultiple lines Authentication Requestmake request for something that is quite far away and requires a really long label to take all the space between the objectsvalidate credentialsAuthentication ResponseAnother authentication Requestdo it later storedAnother authentication Response diff --git a/e2etests/testdata/stable/sequence_diagram_span/dagre/board.exp.json b/e2etests/testdata/stable/sequence_diagram_span/dagre/board.exp.json index a8d1c897c..7508fc49c 100644 --- a/e2etests/testdata/stable/sequence_diagram_span/dagre/board.exp.json +++ b/e2etests/testdata/stable/sequence_diagram_span/dagre/board.exp.json @@ -6,10 +6,10 @@ "type": "", "pos": { "x": 0, - "y": 62 + "y": 50 }, "width": 150, - "height": 128, + "height": 126, "opacity": 1, "strokeDash": 0, "strokeWidth": 2, @@ -45,7 +45,7 @@ "type": "rectangle", "pos": { "x": 69, - "y": 304 + "y": 290 }, "width": 12, "height": 1592, @@ -83,7 +83,7 @@ "type": "", "pos": { "x": 220, - "y": 64 + "y": 50 }, "width": 200, "height": 126, @@ -122,7 +122,7 @@ "type": "rectangle", "pos": { "x": 314, - "y": 304 + "y": 290 }, "width": 12, "height": 162, @@ -163,7 +163,7 @@ "y": 50 }, "width": 150, - "height": 140, + "height": 126, "opacity": 1, "strokeDash": 0, "strokeWidth": 2, @@ -199,7 +199,7 @@ "type": "rectangle", "pos": { "x": 559, - "y": 564 + "y": 550 }, "width": 12, "height": 162, @@ -237,7 +237,7 @@ "type": "", "pos": { "x": 710, - "y": 64 + "y": 50 }, "width": 186, "height": 126, @@ -276,7 +276,7 @@ "type": "rectangle", "pos": { "x": 797, - "y": 824 + "y": 810 }, "width": 12, "height": 422, @@ -314,7 +314,7 @@ "type": "rectangle", "pos": { "x": 793, - "y": 954 + "y": 940 }, "width": 20, "height": 162, @@ -352,7 +352,7 @@ "type": "", "pos": { "x": 966, - "y": 64 + "y": 50 }, "width": 160, "height": 126, @@ -391,7 +391,7 @@ "type": "rectangle", "pos": { "x": 1040, - "y": 1084 + "y": 1070 }, "width": 12, "height": 80, @@ -429,7 +429,7 @@ "type": "", "pos": { "x": 1196, - "y": 64 + "y": 50 }, "width": 197, "height": 126, @@ -468,7 +468,7 @@ "type": "rectangle", "pos": { "x": 1288, - "y": 1344 + "y": 1330 }, "width": 12, "height": 80, @@ -506,7 +506,7 @@ "type": "rectangle", "pos": { "x": 559, - "y": 1474 + "y": 1460 }, "width": 12, "height": 80, @@ -544,7 +544,7 @@ "type": "rectangle", "pos": { "x": 559, - "y": 1604 + "y": 1590 }, "width": 12, "height": 80, @@ -582,7 +582,7 @@ "type": "rectangle", "pos": { "x": 1288, - "y": 1734 + "y": 1720 }, "width": 12, "height": 80, @@ -620,7 +620,7 @@ "type": "rectangle", "pos": { "x": 1288, - "y": 1864 + "y": 1850 }, "width": 12, "height": 80, @@ -682,11 +682,11 @@ "route": [ { "x": 81, - "y": 320 + "y": 306 }, { "x": 314, - "y": 320 + "y": 306 } ], "animated": false, @@ -721,11 +721,11 @@ "route": [ { "x": 81, - "y": 450 + "y": 436 }, { "x": 314, - "y": 450 + "y": 436 } ], "animated": false, @@ -760,11 +760,11 @@ "route": [ { "x": 81, - "y": 580 + "y": 566 }, { "x": 559, - "y": 580 + "y": 566 } ], "animated": false, @@ -799,11 +799,11 @@ "route": [ { "x": 81, - "y": 710 + "y": 696 }, { "x": 559, - "y": 710 + "y": 696 } ], "animated": false, @@ -838,11 +838,11 @@ "route": [ { "x": 81, - "y": 840 + "y": 826 }, { "x": 797, - "y": 840 + "y": 826 } ], "animated": false, @@ -877,11 +877,11 @@ "route": [ { "x": 320, - "y": 970 + "y": 956 }, { "x": 793, - "y": 970 + "y": 956 } ], "animated": false, @@ -916,11 +916,11 @@ "route": [ { "x": 813, - "y": 1100 + "y": 1086 }, { "x": 1040, - "y": 1100 + "y": 1086 } ], "animated": false, @@ -955,11 +955,11 @@ "route": [ { "x": 75, - "y": 1230 + "y": 1216 }, { "x": 797, - "y": 1230 + "y": 1216 } ], "animated": false, @@ -994,11 +994,11 @@ "route": [ { "x": 81, - "y": 1360 + "y": 1346 }, { "x": 1288.5, - "y": 1360 + "y": 1346 } ], "animated": false, @@ -1033,11 +1033,11 @@ "route": [ { "x": 81, - "y": 1490 + "y": 1476 }, { "x": 559, - "y": 1490 + "y": 1476 } ], "animated": false, @@ -1072,11 +1072,11 @@ "route": [ { "x": 81, - "y": 1620 + "y": 1606 }, { "x": 559, - "y": 1620 + "y": 1606 } ], "animated": false, @@ -1111,11 +1111,11 @@ "route": [ { "x": 81, - "y": 1750 + "y": 1736 }, { "x": 1288.5, - "y": 1750 + "y": 1736 } ], "animated": false, @@ -1150,11 +1150,11 @@ "route": [ { "x": 81, - "y": 1880 + "y": 1866 }, { "x": 1288.5, - "y": 1880 + "y": 1866 } ], "animated": false, @@ -1189,11 +1189,11 @@ "route": [ { "x": 75, - "y": 190 + "y": 176 }, { "x": 75, - "y": 2010 + "y": 1996 } ], "animated": false, @@ -1228,11 +1228,11 @@ "route": [ { "x": 320, - "y": 190 + "y": 176 }, { "x": 320, - "y": 2010 + "y": 1996 } ], "animated": false, @@ -1267,11 +1267,11 @@ "route": [ { "x": 565, - "y": 190 + "y": 176 }, { "x": 565, - "y": 2010 + "y": 1996 } ], "animated": false, @@ -1306,11 +1306,11 @@ "route": [ { "x": 803, - "y": 190 + "y": 176 }, { "x": 803, - "y": 2010 + "y": 1996 } ], "animated": false, @@ -1345,11 +1345,11 @@ "route": [ { "x": 1046, - "y": 190 + "y": 176 }, { "x": 1046, - "y": 2010 + "y": 1996 } ], "animated": false, @@ -1384,11 +1384,11 @@ "route": [ { "x": 1294.5, - "y": 190 + "y": 176 }, { "x": 1294.5, - "y": 2010 + "y": 1996 } ], "animated": false, diff --git a/e2etests/testdata/stable/sequence_diagram_span/dagre/sketch.exp.svg b/e2etests/testdata/stable/sequence_diagram_span/dagre/sketch.exp.svg index bf69f8d48..e74474a1b 100644 --- a/e2etests/testdata/stable/sequence_diagram_span/dagre/sketch.exp.svg +++ b/e2etests/testdata/stable/sequence_diagram_span/dagre/sketch.exp.svg @@ -2,7 +2,7 @@ scoreritemResponseitemessayRubricconceptitemOutcome getItem() itemgetRubric()rubricapplyTo(essayResp)match(essayResponse)scorenewgetNormalMinimum()getNormalMaximum()setScore(score)setFeedback(missingConcepts) + + + + + + + + + + + + + scoreritemResponseitemessayRubricconceptitemOutcome getItem() itemgetRubric()rubricapplyTo(essayResp)match(essayResponse)scorenewgetNormalMinimum()getNormalMaximum()setScore(score)setFeedback(missingConcepts) - - - - - - - - - - - - - +scoreritemResponseitemessayRubricconceptitemOutcome getItem() itemgetRubric()rubricapplyTo(essayResp)match(essayResponse)scorenewgetNormalMinimum()getNormalMaximum()setScore(score)setFeedback(missingConcepts) + + + + + + + + + + + + + a_shapea_sequenceanotherfinallysequencesequencesequencescoreritemResponseitemessayRubricconceptitemOutcomescorerconceptessayRubricitemitemOutcomeitemResponsescoreritemResponseitemessayRubricconceptitemOutcome getItem()itemgetRubric()rubricapplyTo(essayResp)match(essayResponse)scorenewgetNormalMinimum()getNormalMaximum()setScore(score)setFeedback(missingConcepts)getItem()itemgetRubric()rubricapplyTo(essayResp)match(essayResponse)scorenewgetNormalMinimum()getNormalMaximum()setScore(score)setFeedback(missingConcepts) - - - - - - - - - - - - - - - - - - - - - - - - - +a_shapea_sequenceanotherfinallysequencesequencesequencescoreritemResponseitemessayRubricconceptitemOutcomescorerconceptessayRubricitemitemOutcomeitemResponsescoreritemResponseitemessayRubricconceptitemOutcome getItem()itemgetRubric()rubricapplyTo(essayResp)match(essayResponse)scorenewgetNormalMinimum()getNormalMaximum()setScore(score)setFeedback(missingConcepts)getItem()itemgetRubric()rubricapplyTo(essayResp)match(essayResponse)scorenewgetNormalMinimum()getNormalMaximum()setScore(score)setFeedback(missingConcepts) + + + + + + + + + + + + + + + + + + + + + + + + + a_shapea_sequenceanotherfinallysequencesequencesequencescoreritemResponseitemessayRubricconceptitemOutcomescorerconceptessayRubricitemitemOutcomeitemResponsescoreritemResponseitemessayRubricconceptitemOutcome getItem()itemgetRubric()rubricapplyTo(essayResp)match(essayResponse)scorenewgetNormalMinimum()getNormalMaximum()setScore(score)setFeedback(missingConcepts)getItem()itemgetRubric()rubricapplyTo(essayResp)match(essayResponse)scorenewgetNormalMinimum()getNormalMaximum()setScore(score)setFeedback(missingConcepts) - - - - - - - - - - - - - - - - - - - - - - - - - +a_shapea_sequenceanotherfinallysequencesequencesequencescoreritemResponseitemessayRubricconceptitemOutcomescorerconceptessayRubricitemitemOutcomeitemResponsescoreritemResponseitemessayRubricconceptitemOutcome getItem()itemgetRubric()rubricapplyTo(essayResp)match(essayResponse)scorenewgetNormalMinimum()getNormalMaximum()setScore(score)setFeedback(missingConcepts)getItem()itemgetRubric()rubricapplyTo(essayResp)match(essayResponse)scorenewgetNormalMinimum()getNormalMaximum()setScore(score)setFeedback(missingConcepts) + + + + + + + + + + + + + + + + + + + + + + + + +