From 112558d9015e0ce784d318c75452fcceb687a4c7 Mon Sep 17 00:00:00 2001 From: Alexander Wang Date: Sun, 12 Feb 2023 10:28:55 -0800 Subject: [PATCH] changelog --- ci/release/changelogs/next.md | 2 ++ d2layouts/d2sequence/sequence_diagram.go | 4 ---- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/ci/release/changelogs/next.md b/ci/release/changelogs/next.md index e34faad22..c8eb0dc2a 100644 --- a/ci/release/changelogs/next.md +++ b/ci/release/changelogs/next.md @@ -25,6 +25,7 @@ - Ensures labels fit inside shapes with shape-specific inner bounding boxes. [#702](https://github.com/terrastruct/d2/pull/702) - dagre container labels changed positions to outside the shape. Many previously obscured container labels are now legible. [#788](https://github.com/terrastruct/d2/pull/788) - Improves package shape dimensions with short height. [#702](https://github.com/terrastruct/d2/pull/702) +- Sequence diagrams are rendered more compacted, both vertically and horizontally. [#796](https://github.com/terrastruct/d2/pull/796) - Keeps person shape from becoming too distorted. [#702](https://github.com/terrastruct/d2/pull/702) - Ensures shapes with icons have enough padding for their labels. [#702](https://github.com/terrastruct/d2/pull/702) - `--force-appendix` flag adds an appendix to SVG outputs with tooltips or links. [#761](https://github.com/terrastruct/d2/pull/761) @@ -37,5 +38,6 @@ - Fixes groups overlapping in sequence diagrams when they end in a self loop. [#728](https://github.com/terrastruct/d2/pull/728) - Fixes dimensions of unlabeled squares or circles with only a set width or height. [#702](https://github.com/terrastruct/d2/pull/702) - Fixes scaling of actor shapes in sequence diagrams. [#702](https://github.com/terrastruct/d2/pull/702) +- Sequence diagram note ordering was sometimes wrong. [#796](https://github.com/terrastruct/d2/pull/796) - Images can now be set to sizes smaller than 128x128. [#702](https://github.com/terrastruct/d2/pull/702) - Fixes class height when there are no rows. [#756](https://github.com/terrastruct/d2/pull/756) diff --git a/d2layouts/d2sequence/sequence_diagram.go b/d2layouts/d2sequence/sequence_diagram.go index c0b070e9b..53cdc8e86 100644 --- a/d2layouts/d2sequence/sequence_diagram.go +++ b/d2layouts/d2sequence/sequence_diagram.go @@ -288,10 +288,6 @@ func (sd *sequenceDiagram) adjustGroupLabel(group *d2graph.Object) { group.Height += float64(heightAdd) - // Spans are special - // If a span starts above the group, then extend it - // Otherwise, move it down - // Extend stuff within this group for _, g := range sd.groups { if g.TopLeft.Y < group.TopLeft.Y && g.TopLeft.Y+g.Height > group.TopLeft.Y {