luciano/d2
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #580 from alixander/sign

Browse source 
add line about signing commits to CONTRIBUTING.md
This commit is contained in:
Alexander Wang 2022-12-31 15:52:24 -08:00 committed by GitHub
commit 2a19ff8ad2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
docs/CONTRIBUTING.md
View file

@ -40,6 +40,8 @@ The simplified D2 flow at a package level looks like:
## Logistics ## Logistics
- Use Go 1.18. Go 1.19's autofmt inexplicably strips spacing from ASCII art in comments. - Use Go 1.18. Go 1.19's autofmt inexplicably strips spacing from ASCII art in comments.
- Please sign your commits
([https://github.com/terrastruct/d2/pull/557#issuecomment-1367468730](https://github.com/terrastruct/d2/pull/557#issuecomment-1367468730)).
- D2 uses Issues as TODOs. No auto-closing on staleness. - D2 uses Issues as TODOs. No auto-closing on staleness.
- Branch off `master`. - Branch off `master`.
- Prefix pull request titles with a short descriptor of the domain, e.g. `d2renderer: Add - Prefix pull request titles with a short descriptor of the domain, e.g. `d2renderer: Add