luciano/d2
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

removed useless TODOs

Browse source
This commit is contained in:
Vojtěch Fošnár 2023-01-10 11:34:42 +01:00
parent 2849624c65
commit 3160f88e5c
No known key found for this signature in database
GPG key ID: 657727E71C40859A
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
d2renderers/d2svg/d2svg.go
View file

@ -1241,10 +1241,10 @@ func Render(diagram *d2target.Diagram, opts *RenderOpts) ([]byte, error) {
// TODO minify // TODO minify
// TODO background stuff. e.g. dotted, grid, colors // TODO background stuff. e.g. dotted, grid, colors
backgroundEl := svg_style.NewThemableElement("rect") backgroundEl := svg_style.NewThemableElement("rect")
backgroundEl.X = float64(tl.X - pad - 10) // TODO the background is not rendered all over the image backgroundEl.X = float64(tl.X - pad)
backgroundEl.Y = float64(tl.Y - pad - 10) // so I had to add 10 to the size - someone smarter than me please fix this backgroundEl.Y = float64(tl.Y - pad)
backgroundEl.Width = float64(w + 10*2) // new observations: adding even 10 to the size seems to fail at higher image sizes? backgroundEl.Width = float64(w)
backgroundEl.Height = float64(h + 10*2) backgroundEl.Height = float64(h)
backgroundEl.Fill = color.N7 backgroundEl.Fill = color.N7
// generate elements that will be appended to the SVG tag // generate elements that will be appended to the SVG tag
@ -1323,7 +1323,7 @@ func singleThemeRulesets(themeID int64) (rulesets string) {
theme.Colors.Neutrals.N1, theme.Colors.Neutrals.N2, theme.Colors.Neutrals.N3, theme.Colors.Neutrals.N1, theme.Colors.Neutrals.N2, theme.Colors.Neutrals.N3,
theme.Colors.Neutrals.N7, theme.Colors.Neutrals.N6, theme.Colors.Neutrals.N7, theme.Colors.Neutrals.N6,
theme.Colors.B1, theme.Colors.B2, theme.Colors.B1, theme.Colors.B2,
theme.Colors.Neutrals.N6, // TODO maybe N5 --color-border-default theme.Colors.Neutrals.N6,
theme.Colors.B2, theme.Colors.B2, theme.Colors.B2, theme.Colors.B2,
theme.Colors.Neutrals.N2, // TODO or N3 --color-attention-subtle theme.Colors.Neutrals.N2, // TODO or N3 --color-attention-subtle
"red", "red",