luciano/d2
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

pr comment

Browse source
This commit is contained in:
Júlio César Batista 2023-01-06 16:49:17 -03:00
parent 3d77318b87
commit 567009971d
No known key found for this signature in database
GPG key ID: 10C4B861BF314878
2 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ci/release/changelogs/next.md
View file

@ -7,10 +7,6 @@
#### Bugfixes ⛑️ #### Bugfixes ⛑️
- Restricts where `near` key constant values can be used, with good error messages, instead of erroring (e.g. setting `near: top-center` on a container would cause bad layouts or error). [#538](https://github.com/terrastruct/d2/pull/538)
- Fixes an error during ELK layout when images had empty labels. [#555](https://github.com/terrastruct/d2/pull/555)
- Fixes rendering classes and tables with empty headers. [#498](https://github.com/terrastruct/d2/pull/498)
- Fixes rendering sql tables with no columns. [#553](https://github.com/terrastruct/d2/pull/553)
- Appendix seperator line no longer added to PNG export when appendix doesn't exist. [#582](https://github.com/terrastruct/d2/pull/582) - Appendix seperator line no longer added to PNG export when appendix doesn't exist. [#582](https://github.com/terrastruct/d2/pull/582)
- Watch mode only fits to screen on initial load. [#601](https://github.com/terrastruct/d2/pull/601) - Watch mode only fits to screen on initial load. [#601](https://github.com/terrastruct/d2/pull/601)
- Dimensions (`width`/`height`) were incorrectly giving compiler errors when applied on a shape with style. [#614](https://github.com/terrastruct/d2/pull/614) - Dimensions (`width`/`height`) were incorrectly giving compiler errors when applied on a shape with style. [#614](https://github.com/terrastruct/d2/pull/614)

4
d2compiler/compile.go
View file

@ -666,7 +666,7 @@ func (c *compiler) compileSQLTable(obj *d2graph.Object) {
obj.SQLTable = &d2target.SQLTable{} obj.SQLTable = &d2target.SQLTable{}
parentID := obj.Parent.AbsID() parentID := obj.Parent.AbsID()
prefixTableID := obj.AbsID() + "." tableIDPrefix := obj.AbsID() + "."
for _, col := range obj.ChildrenArray { for _, col := range obj.ChildrenArray {
if col.IDVal == "style" { if col.IDVal == "style" {
continue continue
@ -702,7 +702,7 @@ func (c *compiler) compileSQLTable(obj *d2graph.Object) {
srcID := e.Src.AbsID() srcID := e.Src.AbsID()
dstID := e.Dst.AbsID() dstID := e.Dst.AbsID()
// skip edges between columns of the same table // skip edges between columns of the same table
if strings.HasPrefix(srcID, prefixTableID) && strings.HasPrefix(dstID, prefixTableID) { if strings.HasPrefix(srcID, tableIDPrefix) && strings.HasPrefix(dstID, tableIDPrefix) {
continue continue
} }
if srcID == absID { if srcID == absID {