luciano/d2
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

change spans base size and growth factor

Browse source
This commit is contained in:
Júlio César Batista 2022-12-02 13:54:40 -08:00
parent 2fdc1e7c76
commit 641850cf5e
No known key found for this signature in database
GPG key ID: 10C4B861BF314878
3 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
d2layouts/d2sequence/constants.go
View file

@ -12,10 +12,10 @@ const MIN_ACTOR_DISTANCE = 200.
const MIN_MESSAGE_DISTANCE = 100. const MIN_MESSAGE_DISTANCE = 100.
// default size // default size
const SPAN_WIDTH = 20. const SPAN_BASE_WIDTH = 12.
// as the spans start getting nested, their size grows // as the spans start getting nested, their size grows
const SPAN_DEPTH_GROW_FACTOR = 10. const SPAN_DEPTH_GROWTH_FACTOR = 8.
// when a span has a single messages // when a span has a single messages
const MIN_SPAN_HEIGHT = MIN_MESSAGE_DISTANCE / 2. const MIN_SPAN_HEIGHT = 80.

4
d2layouts/d2sequence/layout_test.go
View file

@ -251,8 +251,8 @@ func TestSpansSequenceDiagram(t *testing.T) {
t.Fatalf("expected a.t1 height to be %.5f, got %.5f", expectedHeight, a_t1.Height) t.Fatalf("expected a.t1 height to be %.5f, got %.5f", expectedHeight, a_t1.Height)
} }
if a_t1.Width != SPAN_WIDTH { if a_t1.Width != SPAN_BASE_WIDTH {
t.Fatalf("expected span width to be %.5f, got %.5f", SPAN_WIDTH, a_t1.Width) t.Fatalf("expected span width to be %.5f, got %.5f", SPAN_BASE_WIDTH, a_t1.Width)
} }
// check positions // check positions

6
d2layouts/d2sequence/sequence_diagram.go
View file

@ -201,16 +201,16 @@ func (sd *sequenceDiagram) placeSpans() {
// if it is the same as the child top left, add some padding // if it is the same as the child top left, add some padding
minY := math.Min(minMessageY, minChildY) minY := math.Min(minMessageY, minChildY)
if minY == minChildY { if minY == minChildY {
minY -= SPAN_DEPTH_GROW_FACTOR minY -= SPAN_DEPTH_GROWTH_FACTOR
} }
maxY := math.Max(maxMessageY, maxChildY) maxY := math.Max(maxMessageY, maxChildY)
if maxY == maxChildY { if maxY == maxChildY {
maxY += SPAN_DEPTH_GROW_FACTOR maxY += SPAN_DEPTH_GROWTH_FACTOR
} }
height := math.Max(maxY-minY, MIN_SPAN_HEIGHT) height := math.Max(maxY-minY, MIN_SPAN_HEIGHT)
// -2 because the actors count as level 1 making the first level span getting 2*SPAN_DEPTH_GROW_FACTOR // -2 because the actors count as level 1 making the first level span getting 2*SPAN_DEPTH_GROW_FACTOR
width := SPAN_WIDTH + (float64(span.Level()-2) * SPAN_DEPTH_GROW_FACTOR) width := SPAN_BASE_WIDTH + (float64(span.Level()-2) * SPAN_DEPTH_GROWTH_FACTOR)
x := rankToX[sd.objectRank[span]] - (width / 2.) x := rankToX[sd.objectRank[span]] - (width / 2.)
span.Box = geo.NewBox(geo.NewPoint(x, minY), width, height) span.Box = geo.NewBox(geo.NewPoint(x, minY), width, height)
span.ZIndex = 1 span.ZIndex = 1