From 676370d72f4cb0f399543eb752dae60a2823db47 Mon Sep 17 00:00:00 2001 From: Alexander Wang Date: Tue, 26 Sep 2023 11:30:42 -0700 Subject: [PATCH] bump go version in docker --- ci/release/build_in_docker.sh | 2 +- d2plugin/plugin.go | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/ci/release/build_in_docker.sh b/ci/release/build_in_docker.sh index b8a4f1f6c..034d842e4 100755 --- a/ci/release/build_in_docker.sh +++ b/ci/release/build_in_docker.sh @@ -4,7 +4,7 @@ cd -- "$(dirname "$0")/../.." . ./ci/sub/lib.sh tag="$(sh_c docker build \ - --build-arg GOVERSION="1.19.3.linux-$ARCH" \ + --build-arg GOVERSION="1.20.8.linux-$ARCH" \ -qf ./ci/release/linux/Dockerfile ./ci/release/linux)" docker_run \ -e DRY_RUN \ diff --git a/d2plugin/plugin.go b/d2plugin/plugin.go index d52c6b4e0..cb6f80e04 100644 --- a/d2plugin/plugin.go +++ b/d2plugin/plugin.go @@ -152,7 +152,6 @@ func ListPluginInfos(ctx context.Context, ps []Plugin) ([]*PluginInfo, error) { // 1. It first searches the bundled plugins in the global plugins slice. // 2. If not found, it then searches each directory in $PATH for a binary with the name // d2plugin-. -// **NOTE** When D2 upgrades to go 1.19, remember to ignore exec.ErrDot // 3. If such a binary is found, it builds an execPlugin in exec.go // to get a plugin implementation around the binary and returns it. func FindPlugin(ctx context.Context, ps []Plugin, name string) (Plugin, error) {