From 6dee552e1a0e44a6006385c0278ec724603ca289 Mon Sep 17 00:00:00 2001 From: Alexander Wang Date: Tue, 21 Feb 2023 20:26:20 -0800 Subject: [PATCH] nvm on 1 --- d2compiler/compile.go | 7 ------- d2compiler/compile_test.go | 8 -------- .../TestCompile/positions_disjoint.exp.json | 12 ------------ 3 files changed, 27 deletions(-) delete mode 100644 testdata/d2compiler/TestCompile/positions_disjoint.exp.json diff --git a/d2compiler/compile.go b/d2compiler/compile.go index 0b3ed9ed0..3d4a55a7f 100644 --- a/d2compiler/compile.go +++ b/d2compiler/compile.go @@ -612,13 +612,6 @@ func (c *compiler) validateKey(obj *d2graph.Object, f *d2ir.Field) { } } - if keyword == "top" && obj.Attributes.Left == nil { - c.errorf(f.LastPrimaryKey(), `keyword "top" currently cannot be set without also setting "left"`) - } - if keyword == "left" && obj.Attributes.Top == nil { - c.errorf(f.LastPrimaryKey(), `keyword "left" currently cannot be set without also setting "top"`) - } - switch f.Name { case "style": if obj.Attributes.Style.ThreeDee != nil { diff --git a/d2compiler/compile_test.go b/d2compiler/compile_test.go index 9a09dbda7..3b6f2ac6a 100644 --- a/d2compiler/compile_test.go +++ b/d2compiler/compile_test.go @@ -124,14 +124,6 @@ x: { tassert.Equal(t, "200", g.Objects[0].Attributes.Top.Value) }, }, - { - name: "positions_disjoint", - text: `hey: { - top: 200 -} -`, - expErr: `d2/testdata/d2compiler/TestCompile/positions_disjoint.d2:2:2: keyword "top" currently cannot be set without also setting "left"`, - }, { name: "positions_negative", text: `hey: { diff --git a/testdata/d2compiler/TestCompile/positions_disjoint.exp.json b/testdata/d2compiler/TestCompile/positions_disjoint.exp.json deleted file mode 100644 index cced8f7d8..000000000 --- a/testdata/d2compiler/TestCompile/positions_disjoint.exp.json +++ /dev/null @@ -1,12 +0,0 @@ -{ - "graph": null, - "err": { - "ioerr": null, - "errs": [ - { - "range": "d2/testdata/d2compiler/TestCompile/positions_disjoint.d2,1:1:8-1:9:16", - "errmsg": "d2/testdata/d2compiler/TestCompile/positions_disjoint.d2:2:2: keyword \"top\" currently cannot be set without also setting \"left\"" - } - ] - } -}