BoardContainer -> IsContainerOnly

As discussed on slack.
This commit is contained in:
Anmol Sethi 2023-02-27 14:25:37 -08:00
parent 89394421f8
commit 78b09f5007
No known key found for this signature in database
GPG key ID: 25BC68888A99A8BA
642 changed files with 2363 additions and 676 deletions

View file

@ -73,7 +73,7 @@ func (c *compiler) compileBoard(g *d2graph.Graph, ir *d2ir.Map) *d2graph.Graph {
c.compileBoardsField(g, ir, "steps")
if d2ir.ParentMap(ir).CopyBase(nil).Equal(ir.CopyBase(nil)) {
if len(g.Layers) > 0 || len(g.Scenarios) > 0 || len(g.Steps) > 0 {
g.BoardContainer = true
g.IsContainerOnly = true
}
}
return g

View file

@ -2133,7 +2133,7 @@ layers: {
},
},
{
name: "boardContainer",
name: "isContainerOnly",
run: func(t *testing.T) {
g := assertCompile(t, `
layers: {
@ -2154,13 +2154,13 @@ layers: {
}
}
`, "")
assert.True(t, g.BoardContainer)
assert.True(t, g.IsContainerOnly)
assert.Equal(t, 2, len(g.Layers))
assert.Equal(t, "one", g.Layers[0].Name)
assert.Equal(t, "two", g.Layers[1].Name)
assert.Equal(t, 2, len(g.Layers[1].Scenarios))
assert.False(t, g.Layers[1].Scenarios[0].BoardContainer)
assert.False(t, g.Layers[1].Scenarios[1].BoardContainer)
assert.False(t, g.Layers[1].Scenarios[0].IsContainerOnly)
assert.False(t, g.Layers[1].Scenarios[1].IsContainerOnly)
},
},
{

View file

@ -16,7 +16,7 @@ func Export(ctx context.Context, g *d2graph.Graph, fontFamily *d2fonts.FontFamil
diagram := d2target.NewDiagram()
applyStyles(&diagram.Root, g.Root)
diagram.Name = g.Name
diagram.BoardContainer = g.BoardContainer
diagram.IsContainerOnly = g.IsContainerOnly
if fontFamily == nil {
fontFamily = go2.Pointer(d2fonts.SourceSansPro)
}

View file

@ -29,12 +29,11 @@ const MIN_SHAPE_SIZE = 5
type Graph struct {
Name string `json:"name"`
// A BoardContainer is a board or scenario itself contains nothing
// but its base and more boards, scenarios or steps.
// boardContainers do not have a render and are used purely for organizing the board
// tree.
BoardContainer bool `json:"boardContainer"`
AST *d2ast.Map `json:"ast"`
// IsContainerOnly indicates a board or scenario itself makes no modifications from its
// base. Container only boards do not have a render and are used purely for organizing
// the board tree.
IsContainerOnly bool `json:"isContainerOnly"`
AST *d2ast.Map `json:"ast"`
Root *Object `json:"root"`
Edges []*Edge `json:"edges"`

File diff suppressed because one or more lines are too long

Before

Width:  |  Height:  |  Size: 247 KiB

After

Width:  |  Height:  |  Size: 247 KiB

File diff suppressed because one or more lines are too long

Before

Width:  |  Height:  |  Size: 247 KiB

After

Width:  |  Height:  |  Size: 247 KiB

View file

@ -36,9 +36,9 @@ var BorderOffset = geo.NewVector(5, 5)
type Diagram struct {
Name string `json:"name"`
// See docs on the same field in d2graph to understand what it means.
BoardContainer bool `json:"boardContainer"`
Description string `json:"description,omitempty"`
FontFamily *d2fonts.FontFamily `json:"fontFamily,omitempty"`
IsContainerOnly bool `json:"isContainerOnly"`
Description string `json:"description,omitempty"`
FontFamily *d2fonts.FontFamily `json:"fontFamily,omitempty"`
Shapes []Shape `json:"shapes"`
Connections []Connection `json:"connections"`

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [],
"connections": [],

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [],
"connections": [],

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

View file

@ -1,6 +1,6 @@
{
"name": "",
"boardContainer": false,
"isContainerOnly": false,
"fontFamily": "SourceSansPro",
"shapes": [
{

Some files were not shown because too many files have changed in this diff Show more