Merge pull request #1878 from alixander/delete-nested

d2oracle: fix deleting nested board field
This commit is contained in:
Alexander Wang 2024-03-25 05:24:15 -07:00 committed by GitHub
commit a857903959
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 865 additions and 2 deletions

View file

@ -890,7 +890,7 @@ func Delete(g *d2graph.Graph, boardPath []string, key string) (_ *d2graph.Graph,
baseAST = boardG.BaseAST baseAST = boardG.BaseAST
} }
g2, err := deleteReserved(g, baseAST, mk) g2, err := deleteReserved(g, boardPath, baseAST, mk)
if err != nil { if err != nil {
return nil, err return nil, err
} }
@ -1228,7 +1228,7 @@ func renameConflictsToParent(g *d2graph.Graph, key *d2ast.KeyPath) (*d2graph.Gra
return g, nil return g, nil
} }
func deleteReserved(g *d2graph.Graph, baseAST *d2ast.Map, mk *d2ast.Key) (*d2graph.Graph, error) { func deleteReserved(g *d2graph.Graph, boardPath []string, baseAST *d2ast.Map, mk *d2ast.Key) (*d2graph.Graph, error) {
targetKey := mk.Key targetKey := mk.Key
if len(mk.Edges) == 1 { if len(mk.Edges) == 1 {
if mk.EdgeKey == nil { if mk.EdgeKey == nil {
@ -1243,6 +1243,13 @@ func deleteReserved(g *d2graph.Graph, baseAST *d2ast.Map, mk *d2ast.Key) (*d2gra
var e *d2graph.Edge var e *d2graph.Edge
obj := g.Root obj := g.Root
if len(boardPath) > 0 {
boardG := GetBoardGraph(g, boardPath)
if boardG == nil {
return nil, fmt.Errorf("board %v not found", boardPath)
}
obj = boardG.Root
}
if len(mk.Edges) == 1 { if len(mk.Edges) == 1 {
if mk.Key != nil { if mk.Key != nil {
var ok bool var ok bool

View file

@ -7618,6 +7618,83 @@ a
exp: `*.b exp: `*.b
a a
a.b: null a.b: null
`,
},
{
name: "delete-imported-layer-obj",
text: `layers: {
x: {
...@meow
}
}
`,
fsTexts: map[string]string{
"meow.d2": `a
`,
},
boardPath: []string{"x"},
key: `a`,
exp: `layers: {
x: {
...@meow
a: null
}
}
`,
},
{
name: "delete-not-layer-obj",
text: `b.style.fill: red
layers: {
x: {
a
}
}
`,
key: `b.style.fill`,
exp: `b
layers: {
x: {
a
}
}
`,
},
{
name: "delete-layer-obj",
text: `layers: {
x: {
a
}
}
`,
boardPath: []string{"x"},
key: `a`,
exp: `layers: {
x
}
`,
},
{
name: "delete-layer-style",
text: `layers: {
x: {
a.style.fill: red
}
}
`,
boardPath: []string{"x"},
key: `a.style.fill`,
exp: `layers: {
x: {
a
}
}
`, `,
}, },
} }

View file

@ -0,0 +1,177 @@
{
"graph": {
"name": "",
"isFolderOnly": true,
"ast": {
"range": "index.d2,0:0:0-6:0:48",
"nodes": [
{
"map_key": {
"range": "index.d2,0:0:0-5:1:47",
"key": {
"range": "index.d2,0:0:0-0:6:6",
"path": [
{
"unquoted_string": {
"range": "index.d2,0:0:0-0:6:6",
"value": [
{
"string": "layers",
"raw_string": "layers"
}
]
}
}
]
},
"primary": {},
"value": {
"map": {
"range": "index.d2,0:8:8-5:1:47",
"nodes": [
{
"map_key": {
"range": "index.d2,1:2:12-4:3:45",
"key": {
"range": "index.d2,1:2:12-1:3:13",
"path": [
{
"unquoted_string": {
"range": "index.d2,1:2:12-1:3:13",
"value": [
{
"string": "x",
"raw_string": "x"
}
]
}
}
]
},
"primary": {},
"value": {
"map": {
"range": "index.d2,1:5:15-4:3:45",
"nodes": [
{
"import": {
"range": "index.d2,2:4:21-2:12:29",
"spread": true,
"pre": "",
"path": [
{
"unquoted_string": {
"range": "index.d2,2:8:25-2:12:29",
"value": [
{
"string": "meow",
"raw_string": "meow"
}
]
}
}
]
}
},
{
"map_key": {
"range": "index.d2,3:4:34-3:11:41",
"key": {
"range": "index.d2,3:4:34-3:5:35",
"path": [
{
"unquoted_string": {
"range": "index.d2,3:4:34-3:5:35",
"value": [
{
"string": "a",
"raw_string": "a"
}
]
}
}
]
},
"primary": {},
"value": {
"null": {
"range": "index.d2,3:7:37-3:11:41"
}
}
}
}
]
}
}
}
}
]
}
}
}
}
]
},
"root": {
"id": "",
"id_val": "",
"attributes": {
"label": {
"value": ""
},
"labelDimensions": {
"width": 0,
"height": 0
},
"style": {},
"near_key": null,
"shape": {
"value": ""
},
"direction": {
"value": ""
},
"constraint": null
},
"zIndex": 0
},
"edges": null,
"objects": null,
"layers": [
{
"name": "x",
"isFolderOnly": true,
"ast": {
"range": ",1:0:0-2:0:0",
"nodes": null
},
"root": {
"id": "",
"id_val": "",
"attributes": {
"label": {
"value": ""
},
"labelDimensions": {
"width": 0,
"height": 0
},
"style": {},
"near_key": null,
"shape": {
"value": ""
},
"direction": {
"value": ""
},
"constraint": null
},
"zIndex": 0
},
"edges": null,
"objects": null
}
]
},
"err": "<nil>"
}

89
testdata/d2oracle/TestDelete/delete-layer-obj.exp.json generated vendored Normal file
View file

@ -0,0 +1,89 @@
{
"graph": {
"name": "",
"isFolderOnly": true,
"ast": {
"range": "d2/testdata/d2oracle/TestDelete/delete-layer-obj.d2,0:0:0-3:0:16",
"nodes": [
{
"map_key": {
"range": "d2/testdata/d2oracle/TestDelete/delete-layer-obj.d2,0:0:0-2:1:15",
"key": {
"range": "d2/testdata/d2oracle/TestDelete/delete-layer-obj.d2,0:0:0-0:6:6",
"path": [
{
"unquoted_string": {
"range": "d2/testdata/d2oracle/TestDelete/delete-layer-obj.d2,0:0:0-0:6:6",
"value": [
{
"string": "layers",
"raw_string": "layers"
}
]
}
}
]
},
"primary": {},
"value": {
"map": {
"range": "d2/testdata/d2oracle/TestDelete/delete-layer-obj.d2,0:8:8-2:1:15",
"nodes": [
{
"map_key": {
"range": "d2/testdata/d2oracle/TestDelete/delete-layer-obj.d2,1:2:12-1:3:13",
"key": {
"range": "d2/testdata/d2oracle/TestDelete/delete-layer-obj.d2,1:2:12-1:3:13",
"path": [
{
"unquoted_string": {
"range": "d2/testdata/d2oracle/TestDelete/delete-layer-obj.d2,1:2:12-1:3:13",
"value": [
{
"string": "x",
"raw_string": "x"
}
]
}
}
]
},
"primary": {},
"value": {}
}
}
]
}
}
}
}
]
},
"root": {
"id": "",
"id_val": "",
"attributes": {
"label": {
"value": ""
},
"labelDimensions": {
"width": 0,
"height": 0
},
"style": {},
"near_key": null,
"shape": {
"value": ""
},
"direction": {
"value": ""
},
"constraint": null
},
"zIndex": 0
},
"edges": null,
"objects": null
},
"err": "<nil>"
}

View file

@ -0,0 +1,222 @@
{
"graph": {
"name": "",
"isFolderOnly": true,
"ast": {
"range": "d2/testdata/d2oracle/TestDelete/delete-layer-style.d2,0:0:0-5:0:29",
"nodes": [
{
"map_key": {
"range": "d2/testdata/d2oracle/TestDelete/delete-layer-style.d2,0:0:0-4:1:28",
"key": {
"range": "d2/testdata/d2oracle/TestDelete/delete-layer-style.d2,0:0:0-0:6:6",
"path": [
{
"unquoted_string": {
"range": "d2/testdata/d2oracle/TestDelete/delete-layer-style.d2,0:0:0-0:6:6",
"value": [
{
"string": "layers",
"raw_string": "layers"
}
]
}
}
]
},
"primary": {},
"value": {
"map": {
"range": "d2/testdata/d2oracle/TestDelete/delete-layer-style.d2,0:8:8-4:1:28",
"nodes": [
{
"map_key": {
"range": "d2/testdata/d2oracle/TestDelete/delete-layer-style.d2,1:2:12-3:3:26",
"key": {
"range": "d2/testdata/d2oracle/TestDelete/delete-layer-style.d2,1:2:12-1:3:13",
"path": [
{
"unquoted_string": {
"range": "d2/testdata/d2oracle/TestDelete/delete-layer-style.d2,1:2:12-1:3:13",
"value": [
{
"string": "x",
"raw_string": "x"
}
]
}
}
]
},
"primary": {},
"value": {
"map": {
"range": "d2/testdata/d2oracle/TestDelete/delete-layer-style.d2,1:5:15-3:3:26",
"nodes": [
{
"map_key": {
"range": "d2/testdata/d2oracle/TestDelete/delete-layer-style.d2,2:4:21-2:5:22",
"key": {
"range": "d2/testdata/d2oracle/TestDelete/delete-layer-style.d2,2:4:21-2:5:22",
"path": [
{
"unquoted_string": {
"range": "d2/testdata/d2oracle/TestDelete/delete-layer-style.d2,2:4:21-2:5:22",
"value": [
{
"string": "a",
"raw_string": "a"
}
]
}
}
]
},
"primary": {},
"value": {}
}
}
]
}
}
}
}
]
}
}
}
}
]
},
"root": {
"id": "",
"id_val": "",
"attributes": {
"label": {
"value": ""
},
"labelDimensions": {
"width": 0,
"height": 0
},
"style": {},
"near_key": null,
"shape": {
"value": ""
},
"direction": {
"value": ""
},
"constraint": null
},
"zIndex": 0
},
"edges": null,
"objects": null,
"layers": [
{
"name": "x",
"isFolderOnly": false,
"ast": {
"range": ",1:0:0-2:0:0",
"nodes": [
{
"map_key": {
"range": ",0:0:0-0:0:0",
"key": {
"range": ",0:0:0-0:0:0",
"path": [
{
"unquoted_string": {
"range": ",0:0:0-0:0:0",
"value": [
{
"string": "a"
}
]
}
}
]
},
"primary": {},
"value": {}
}
}
]
},
"root": {
"id": "",
"id_val": "",
"attributes": {
"label": {
"value": ""
},
"labelDimensions": {
"width": 0,
"height": 0
},
"style": {},
"near_key": null,
"shape": {
"value": ""
},
"direction": {
"value": ""
},
"constraint": null
},
"zIndex": 0
},
"edges": null,
"objects": [
{
"id": "a",
"id_val": "a",
"references": [
{
"key": {
"range": "d2/testdata/d2oracle/TestDelete/delete-layer-style.d2,2:4:21-2:5:22",
"path": [
{
"unquoted_string": {
"range": "d2/testdata/d2oracle/TestDelete/delete-layer-style.d2,2:4:21-2:5:22",
"value": [
{
"string": "a",
"raw_string": "a"
}
]
}
}
]
},
"key_path_index": 0,
"map_key_edge_index": -1
}
],
"attributes": {
"label": {
"value": "a"
},
"labelDimensions": {
"width": 0,
"height": 0
},
"style": {},
"near_key": null,
"shape": {
"value": "rectangle"
},
"direction": {
"value": ""
},
"constraint": null
},
"zIndex": 0
}
]
}
]
},
"err": "<nil>"
}

View file

@ -0,0 +1,291 @@
{
"graph": {
"name": "",
"isFolderOnly": false,
"ast": {
"range": "d2/testdata/d2oracle/TestDelete/delete-not-layer-obj.d2,0:0:0-7:0:32",
"nodes": [
{
"map_key": {
"range": "d2/testdata/d2oracle/TestDelete/delete-not-layer-obj.d2,0:0:0-0:1:1",
"key": {
"range": "d2/testdata/d2oracle/TestDelete/delete-not-layer-obj.d2,0:0:0-0:1:1",
"path": [
{
"unquoted_string": {
"range": "d2/testdata/d2oracle/TestDelete/delete-not-layer-obj.d2,0:0:0-0:1:1",
"value": [
{
"string": "b",
"raw_string": "b"
}
]
}
}
]
},
"primary": {},
"value": {}
}
},
{
"map_key": {
"range": "d2/testdata/d2oracle/TestDelete/delete-not-layer-obj.d2,2:0:3-6:1:31",
"key": {
"range": "d2/testdata/d2oracle/TestDelete/delete-not-layer-obj.d2,2:0:3-2:6:9",
"path": [
{
"unquoted_string": {
"range": "d2/testdata/d2oracle/TestDelete/delete-not-layer-obj.d2,2:0:3-2:6:9",
"value": [
{
"string": "layers",
"raw_string": "layers"
}
]
}
}
]
},
"primary": {},
"value": {
"map": {
"range": "d2/testdata/d2oracle/TestDelete/delete-not-layer-obj.d2,2:8:11-6:1:31",
"nodes": [
{
"map_key": {
"range": "d2/testdata/d2oracle/TestDelete/delete-not-layer-obj.d2,3:2:15-5:3:29",
"key": {
"range": "d2/testdata/d2oracle/TestDelete/delete-not-layer-obj.d2,3:2:15-3:3:16",
"path": [
{
"unquoted_string": {
"range": "d2/testdata/d2oracle/TestDelete/delete-not-layer-obj.d2,3:2:15-3:3:16",
"value": [
{
"string": "x",
"raw_string": "x"
}
]
}
}
]
},
"primary": {},
"value": {
"map": {
"range": "d2/testdata/d2oracle/TestDelete/delete-not-layer-obj.d2,3:5:18-5:3:29",
"nodes": [
{
"map_key": {
"range": "d2/testdata/d2oracle/TestDelete/delete-not-layer-obj.d2,4:4:24-4:5:25",
"key": {
"range": "d2/testdata/d2oracle/TestDelete/delete-not-layer-obj.d2,4:4:24-4:5:25",
"path": [
{
"unquoted_string": {
"range": "d2/testdata/d2oracle/TestDelete/delete-not-layer-obj.d2,4:4:24-4:5:25",
"value": [
{
"string": "a",
"raw_string": "a"
}
]
}
}
]
},
"primary": {},
"value": {}
}
}
]
}
}
}
}
]
}
}
}
}
]
},
"root": {
"id": "",
"id_val": "",
"attributes": {
"label": {
"value": ""
},
"labelDimensions": {
"width": 0,
"height": 0
},
"style": {},
"near_key": null,
"shape": {
"value": ""
},
"direction": {
"value": ""
},
"constraint": null
},
"zIndex": 0
},
"edges": null,
"objects": [
{
"id": "b",
"id_val": "b",
"references": [
{
"key": {
"range": "d2/testdata/d2oracle/TestDelete/delete-not-layer-obj.d2,0:0:0-0:1:1",
"path": [
{
"unquoted_string": {
"range": "d2/testdata/d2oracle/TestDelete/delete-not-layer-obj.d2,0:0:0-0:1:1",
"value": [
{
"string": "b",
"raw_string": "b"
}
]
}
}
]
},
"key_path_index": 0,
"map_key_edge_index": -1
}
],
"attributes": {
"label": {
"value": "b"
},
"labelDimensions": {
"width": 0,
"height": 0
},
"style": {},
"near_key": null,
"shape": {
"value": "rectangle"
},
"direction": {
"value": ""
},
"constraint": null
},
"zIndex": 0
}
],
"layers": [
{
"name": "x",
"isFolderOnly": false,
"ast": {
"range": ",1:0:0-2:0:0",
"nodes": [
{
"map_key": {
"range": ",0:0:0-0:0:0",
"key": {
"range": ",0:0:0-0:0:0",
"path": [
{
"unquoted_string": {
"range": ",0:0:0-0:0:0",
"value": [
{
"string": "a"
}
]
}
}
]
},
"primary": {},
"value": {}
}
}
]
},
"root": {
"id": "",
"id_val": "",
"attributes": {
"label": {
"value": ""
},
"labelDimensions": {
"width": 0,
"height": 0
},
"style": {},
"near_key": null,
"shape": {
"value": ""
},
"direction": {
"value": ""
},
"constraint": null
},
"zIndex": 0
},
"edges": null,
"objects": [
{
"id": "a",
"id_val": "a",
"references": [
{
"key": {
"range": "d2/testdata/d2oracle/TestDelete/delete-not-layer-obj.d2,4:4:24-4:5:25",
"path": [
{
"unquoted_string": {
"range": "d2/testdata/d2oracle/TestDelete/delete-not-layer-obj.d2,4:4:24-4:5:25",
"value": [
{
"string": "a",
"raw_string": "a"
}
]
}
}
]
},
"key_path_index": 0,
"map_key_edge_index": -1
}
],
"attributes": {
"label": {
"value": "a"
},
"labelDimensions": {
"width": 0,
"height": 0
},
"style": {},
"near_key": null,
"shape": {
"value": "rectangle"
},
"direction": {
"value": ""
},
"constraint": null
},
"zIndex": 0
}
]
}
]
},
"err": "<nil>"
}