diff --git a/d2graph/d2graph.go b/d2graph/d2graph.go
index 460e60ecd..4001d3fb0 100644
--- a/d2graph/d2graph.go
+++ b/d2graph/d2graph.go
@@ -1011,14 +1011,14 @@ func (g *Graph) SetDimensions(mtexts []*d2target.MText, ruler *textmeasure.Ruler
}
if c.Constraint != "" {
// covers UNQ constraint with padding
- constraintWidth = 70.
+ constraintWidth = 60.
}
}
// The rows get padded a little due to header font being larger than row font
obj.Height = float64(dims.Height * (len(obj.SQLTable.Columns) + 1))
- // Leave room for padding (20 on each side)
- obj.Width = float64(maxNameWidth + maxTypeWidth + constraintWidth + 40)
+ // Leave room for padding (10 name 20 type 20 = 50)
+ obj.Width = float64(maxNameWidth + maxTypeWidth + constraintWidth + 50)
case d2target.ShapeText, d2target.ShapeCode:
}
diff --git a/d2renderers/d2svg/d2svg.go b/d2renderers/d2svg/d2svg.go
index 41a0c63a6..e9e94b686 100644
--- a/d2renderers/d2svg/d2svg.go
+++ b/d2renderers/d2svg/d2svg.go
@@ -589,7 +589,7 @@ func render3dRect(targetShape d2target.Shape) string {
return borderMask + mainRect + renderedSides + renderedBorder
}
-func drawShape(writer io.Writer, targetShape d2target.Shape) (labelMask string, err error) {
+func drawShape(writer io.Writer, targetShape d2target.Shape, ruler *textmeasure.Ruler) (labelMask string, err error) {
fmt.Fprintf(writer, ``, escapeText(targetShape.ID))
tl := geo.NewPoint(float64(targetShape.Pos.X), float64(targetShape.Pos.Y))
width := float64(targetShape.Width)
@@ -629,7 +629,7 @@ func drawShape(writer io.Writer, targetShape d2target.Shape) (labelMask string,
fmt.Fprintf(writer, ``)
return labelMask, nil
case d2target.ShapeSQLTable:
- drawTable(writer, targetShape)
+ drawTable(writer, targetShape, ruler)
fmt.Fprintf(writer, ``)
return labelMask, nil
case d2target.ShapeOval:
@@ -963,7 +963,7 @@ func embedFonts(buf *bytes.Buffer) {
}
// TODO minify output at end
-func Render(diagram *d2target.Diagram, pad int) ([]byte, error) {
+func Render(diagram *d2target.Diagram, ruler *textmeasure.Ruler, pad int) ([]byte, error) {
buf := &bytes.Buffer{}
w, h := setViewbox(buf, diagram, pad)
@@ -1022,7 +1022,7 @@ func Render(diagram *d2target.Diagram, pad int) ([]byte, error) {
labelMasks = append(labelMasks, labelMask)
}
} else if s, is := obj.(d2target.Shape); is {
- labelMask, err := drawShape(buf, s)
+ labelMask, err := drawShape(buf, s, ruler)
if err != nil {
return nil, err
} else if labelMask != "" {
diff --git a/d2renderers/d2svg/table.go b/d2renderers/d2svg/table.go
index ce9e79536..43b0b69bb 100644
--- a/d2renderers/d2svg/table.go
+++ b/d2renderers/d2svg/table.go
@@ -6,11 +6,15 @@ import (
"math"
"strings"
+ "oss.terrastruct.com/d2/d2renderers/d2fonts"
"oss.terrastruct.com/d2/d2target"
"oss.terrastruct.com/d2/lib/geo"
"oss.terrastruct.com/d2/lib/label"
+ "oss.terrastruct.com/d2/lib/textmeasure"
)
+const namePadding = 10
+
func tableHeader(box *geo.Box, text string, textWidth, textHeight, fontSize float64) string {
str := fmt.Sprintf(``,
box.TopLeft.X, box.TopLeft.Y, box.Width, box.Height, "#0a0f25")
@@ -43,7 +47,7 @@ func tableRow(box *geo.Box, nameText, typeText, constraintText string, fontSize,
// e.g. | diagram int FK |
nameTL := label.InsideMiddleLeft.GetPointOnBox(
box,
- prefixPadding,
+ namePadding,
box.Width,
fontSize,
)
@@ -69,7 +73,7 @@ func tableRow(box *geo.Box, nameText, typeText, constraintText string, fontSize,
// TODO light font
fmt.Sprintf(`%s`,
- nameTL.X+longestNameWidth,
+ nameTL.X+longestNameWidth+2*namePadding,
nameTL.Y+fontSize*3/4,
fmt.Sprintf("text-anchor:%s;font-size:%vpx;fill:%s", "start", fontSize, neutralColor),
escapeText(typeText),
@@ -97,7 +101,7 @@ func constraintAbbr(constraint string) string {
}
}
-func drawTable(writer io.Writer, targetShape d2target.Shape) {
+func drawTable(writer io.Writer, targetShape d2target.Shape, ruler *textmeasure.Ruler) {
fmt.Fprintf(writer, ``,
targetShape.Pos.X, targetShape.Pos.Y, targetShape.Width, targetShape.Height, shapeStyle(targetShape))
@@ -113,18 +117,18 @@ func drawTable(writer io.Writer, targetShape d2target.Shape) {
tableHeader(headerBox, targetShape.Label, float64(targetShape.LabelWidth), float64(targetShape.LabelHeight), float64(targetShape.FontSize)),
)
- fontSize := float64(targetShape.FontSize)
+ font := d2fonts.SourceSansPro.Font(targetShape.FontSize, d2fonts.FONT_STYLE_REGULAR)
var longestNameWidth float64
for _, f := range targetShape.SQLTable.Columns {
- // TODO measure text
- longestNameWidth = math.Max(longestNameWidth, float64(len(f.Name))*fontSize*5/9)
+ w, _ := ruler.MeasurePrecise(font, f.Name)
+ longestNameWidth = math.Max(longestNameWidth, w)
}
rowBox := geo.NewBox(box.TopLeft.Copy(), box.Width, rowHeight)
rowBox.TopLeft.Y += headerBox.Height
for _, f := range targetShape.SQLTable.Columns {
fmt.Fprint(writer,
- tableRow(rowBox, f.Name, f.Type, constraintAbbr(f.Constraint), fontSize, longestNameWidth),
+ tableRow(rowBox, f.Name, f.Type, constraintAbbr(f.Constraint), float64(targetShape.FontSize), longestNameWidth),
)
rowBox.TopLeft.Y += rowHeight
fmt.Fprintf(writer, ``,
diff --git a/docs/examples/lib/1-d2lib/d2lib.go b/docs/examples/lib/1-d2lib/d2lib.go
index 8e157d62a..fc16a313b 100644
--- a/docs/examples/lib/1-d2lib/d2lib.go
+++ b/docs/examples/lib/1-d2lib/d2lib.go
@@ -20,6 +20,6 @@ func main() {
Ruler: ruler,
ThemeID: d2themescatalog.GrapeSoda.ID,
})
- out, _ := d2svg.Render(diagram, d2svg.DEFAULT_PADDING)
+ out, _ := d2svg.Render(diagram, ruler, d2svg.DEFAULT_PADDING)
_ = ioutil.WriteFile(filepath.Join("out.svg"), out, 0600)
}
diff --git a/docs/examples/lib/3-lowlevel/lowlevel.go b/docs/examples/lib/3-lowlevel/lowlevel.go
index 066558e42..70c579dba 100644
--- a/docs/examples/lib/3-lowlevel/lowlevel.go
+++ b/docs/examples/lib/3-lowlevel/lowlevel.go
@@ -21,6 +21,6 @@ func main() {
_ = graph.SetDimensions(nil, ruler)
_ = d2dagrelayout.Layout(context.Background(), graph)
diagram, _ := d2exporter.Export(context.Background(), graph, d2themescatalog.NeutralDefault.ID)
- out, _ := d2svg.Render(diagram, d2svg.DEFAULT_PADDING)
+ out, _ := d2svg.Render(diagram, ruler, d2svg.DEFAULT_PADDING)
_ = ioutil.WriteFile(filepath.Join("out.svg"), out, 0600)
}
diff --git a/e2etests/e2e_test.go b/e2etests/e2e_test.go
index bade9f613..bf69db6dc 100644
--- a/e2etests/e2e_test.go
+++ b/e2etests/e2e_test.go
@@ -125,7 +125,7 @@ func run(t *testing.T, tc testCase) {
dataPath := filepath.Join("testdata", strings.TrimPrefix(t.Name(), "TestE2E/"), layoutName)
pathGotSVG := filepath.Join(dataPath, "sketch.got.svg")
- svgBytes, err := d2svg.Render(diagram, d2svg.DEFAULT_PADDING)
+ svgBytes, err := d2svg.Render(diagram, ruler, d2svg.DEFAULT_PADDING)
assert.Success(t, err)
err = os.MkdirAll(dataPath, 0755)
assert.Success(t, err)
diff --git a/main.go b/main.go
index 53ef5d201..b7f8d617a 100644
--- a/main.go
+++ b/main.go
@@ -214,7 +214,7 @@ func compile(ctx context.Context, ms *xmain.State, plugin d2plugin.Plugin, pad,
return nil, false, err
}
- svg, err := d2svg.Render(diagram, int(pad))
+ svg, err := d2svg.Render(diagram, ruler, int(pad))
if err != nil {
return nil, false, err
}