From b7a0219680959d08a0bcb57fc82b4e9993a43305 Mon Sep 17 00:00:00 2001 From: melsonic Date: Sat, 12 Apr 2025 23:19:54 +0530 Subject: [PATCH] moved gradient test location --- d2compiler/compile_test.go | 14 --- d2renderers/d2sketch/sketch_test.go | 8 ++ .../sketch.exp.svg | 118 ++++++++++++++++++ lib/color/color.go | 2 + 4 files changed, 128 insertions(+), 14 deletions(-) create mode 100644 d2renderers/d2sketch/testdata/test-gradient-fill-values-in-sketch-mode/sketch.exp.svg diff --git a/d2compiler/compile_test.go b/d2compiler/compile_test.go index b2ec3e863..5a56d1e89 100644 --- a/d2compiler/compile_test.go +++ b/d2compiler/compile_test.go @@ -3894,20 +3894,6 @@ svc_1.t2 -> b: do with B tassert.Equal(t, "d2/testdata/d2compiler/TestCompile/meow.d2", g.Layers[0].Layers[0].AST.Range.Path) }, }, - { - name: "test-gradient-fill-values-in-sketch-mode", - text: ` - vars: { - d2-config: { - sketch: true - } - } - x->y - x.style.fill: "linear-gradient(#000000, #ffffff)" - y.style.fill: "linear-gradient(#ffffff, #000000)" - `, - expErr: "", - }, } for _, tc := range testCases { diff --git a/d2renderers/d2sketch/sketch_test.go b/d2renderers/d2sketch/sketch_test.go index 04b97e134..579af9633 100644 --- a/d2renderers/d2sketch/sketch_test.go +++ b/d2renderers/d2sketch/sketch_test.go @@ -1357,6 +1357,14 @@ item -> customer: is(Adult) customer -> item: true `, }, + { + name: "test-gradient-fill-values-in-sketch-mode", + script: ` + x->y + x.style.fill: "linear-gradient(#000000,#ffffff)" + y.style.fill: "linear-gradient(#ffffff,#000000)" + `, + }, } runa(t, tcs) } diff --git a/d2renderers/d2sketch/testdata/test-gradient-fill-values-in-sketch-mode/sketch.exp.svg b/d2renderers/d2sketch/testdata/test-gradient-fill-values-in-sketch-mode/sketch.exp.svg new file mode 100644 index 000000000..d6fb8498c --- /dev/null +++ b/d2renderers/d2sketch/testdata/test-gradient-fill-values-in-sketch-mode/sketch.exp.svg @@ -0,0 +1,118 @@ + + + + + + + + + + + + + + + + + + +xy + + + + \ No newline at end of file diff --git a/lib/color/color.go b/lib/color/color.go index fccb2a79c..7417a2b9d 100644 --- a/lib/color/color.go +++ b/lib/color/color.go @@ -86,6 +86,8 @@ func darkenCSS(colorString string) (string, error) { } func LuminanceCategory(colorString string) (string, error) { + // check if colorString matches the `url('#grad-')` format + // which is used to refer to a or element. if IsURLGradientID(colorString) { return "normal", nil }