Merge pull request #820 from alixander/fix-dagre-disconnect

fix dagre disconnect edge case

ci/release/changelogs/next.md

@@ -3,3 +3,5 @@
 #### Improvements 🧹
 
 #### Bugfixes ⛑️
+
+- Fixes edge case where layouts with dagre show a connection from the bottom side of shapes being slightly disconnected from the shape. [#820](https://github.com/terrastruct/d2/pull/820)

d2layouts/d2dagrelayout/layout.go

@@ -350,7 +350,8 @@ func Layout(ctx context.Context, g *d2graph.Graph, opts *ConfigurableOpts) (err
 					return true
 				}
 				// Edge should only move if it's not connected to the bottom side of the shrinking container
-				return p.Y != obj.TopLeft.Y+obj.Height
+				// Give some margin for error
+				return !(obj.TopLeft.Y+obj.Height-1 <= p.Y && obj.TopLeft.Y+obj.Height+1 >= p.Y && p.X != obj.TopLeft.X && p.X != (obj.TopLeft.X+obj.Width))
 			}
 			for _, e := range g.Edges {
 				if _, ok := movedEdges[e]; ok {

e2etests/regression_test.go

@@ -489,6 +489,32 @@ group: {
 }
 &foo
 &&bar
+`,
+		},
+		{
+			name: "dagre-disconnect",
+			script: `a: {
+  k.t -> f.i
+  f.g -> _.s.n
+}
+k
+k.s <-> u.o
+h.m.s -> a.f.g
+
+a.f.j -> u.s.j
+u: {
+  c -> _.s.z.c
+}
+
+s: {
+  n: {
+    style.stroke: red
+    f
+  }
+}
+
+s.n -> y.r: {style.stroke-width: 8; style.stroke: red}
+y.r -> a.g.i: 1\n2\n3\n4
 `,
 		},
 	}