luciano/d2
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #1131 from alixander/update-atan2

Browse source 
atan2
This commit is contained in:
Alexander Wang 2023-04-03 12:55:49 -07:00 committed by GitHub
commit c1b085da6e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/shape/shape_oval.go
View file

@ -35,7 +35,7 @@ func (s shapeOval) GetInnerBox() *geo.Box {
} }
func (s shapeOval) GetDimensionsToFit(width, height, paddingX, paddingY float64) (float64, float64) { func (s shapeOval) GetDimensionsToFit(width, height, paddingX, paddingY float64) (float64, float64) {
theta := math.Atan2(height, width) theta := float64(float32(math.Atan2(height, width)))
// add padding in direction of diagonal so there is padding distance between top left and border // add padding in direction of diagonal so there is padding distance between top left and border
paddedWidth := width + paddingX*math.Cos(theta) paddedWidth := width + paddingX*math.Cos(theta)
paddedHeight := height + paddingY*math.Sin(theta) paddedHeight := height + paddingY*math.Sin(theta)
@ -59,7 +59,7 @@ func (s shapeOval) GetInsidePlacement(width, height, paddingX, paddingY float64)
// ├───cos*r───┤ // ├───cos*r───┤
rx := s.Box.Width / 2 rx := s.Box.Width / 2
ry := s.Box.Height / 2 ry := s.Box.Height / 2
theta := math.Atan2(ry, rx) theta := float64(float32(math.Atan2(ry, rx)))
sin := math.Sin(theta) sin := math.Sin(theta)
cos := math.Cos(theta) cos := math.Cos(theta)
// r is the ellipse radius on the line between node.TopLeft and the ellipse center // r is the ellipse radius on the line between node.TopLeft and the ellipse center