From ceaf2fb6815ccfe8b7971485afd43be21615579f Mon Sep 17 00:00:00 2001 From: Gavin Nishizawa Date: Wed, 27 Sep 2023 17:04:39 -0700 Subject: [PATCH] remove compile error for nested grids --- d2compiler/compile.go | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/d2compiler/compile.go b/d2compiler/compile.go index fab6d579f..562696574 100644 --- a/d2compiler/compile.go +++ b/d2compiler/compile.go @@ -1092,18 +1092,20 @@ func (c *compiler) validateEdges(g *d2graph.Graph) { srcGrid := edge.Src.Parent.ClosestGridDiagram() dstGrid := edge.Dst.Parent.ClosestGridDiagram() if srcGrid != nil || dstGrid != nil { - if top := srcGrid.TopGridDiagram(); srcGrid != top { - // valid: grid.child1 -> grid.child2 - // invalid: grid.childGrid.child1 -> grid.childGrid.child2 - c.errorf(edge.GetAstEdge(), "edge must be on direct child of grid diagram %#v", top.AbsID()) - continue - } - if top := dstGrid.TopGridDiagram(); dstGrid != top { - // valid: grid.child1 -> grid.child2 - // invalid: grid.childGrid.child1 -> grid.childGrid.child2 - c.errorf(edge.GetAstEdge(), "edge must be on direct child of grid diagram %#v", top.AbsID()) - continue - } + // TODO cleanup + // if top := srcGrid.TopGridDiagram(); srcGrid != top { + // // valid: grid.child1 -> grid.child2 + // // invalid: grid.childGrid.child1 -> grid.childGrid.child2 + // c.errorf(edge.GetAstEdge(), "edge must be on direct child of grid diagram %#v", top.AbsID()) + // continue + // } + // if top := dstGrid.TopGridDiagram(); dstGrid != top { + // // valid: grid.child1 -> grid.child2 + // // invalid: grid.childGrid.child1 -> grid.childGrid.child2 + // c.errorf(edge.GetAstEdge(), "edge must be on direct child of grid diagram %#v", top.AbsID()) + // continue + // } + if srcGrid != dstGrid { // valid: a -> grid // invalid: a -> grid.child