diff --git a/d2layouts/d2cycle/layout.go b/d2layouts/d2cycle/layout.go index a2bc268ec..051b9891a 100644 --- a/d2layouts/d2cycle/layout.go +++ b/d2layouts/d2cycle/layout.go @@ -119,7 +119,7 @@ func createCircularArc(edge *d2graph.Edge) { tangentX /= mag tangentY /= mag } - const MIN_SEGMENT_LEN = 10.0 + const MIN_SEGMENT_LEN = 20.0 // Calculate current segment direction dx := lastPoint.X - secondLastPoint.X dy := lastPoint.Y - secondLastPoint.Y diff --git a/e2etests/testdata/txtar/cycle-diagram/dagre/board.exp.json b/e2etests/testdata/txtar/cycle-diagram/dagre/board.exp.json index f260b0886..6ea0c16f6 100644 --- a/e2etests/testdata/txtar/cycle-diagram/dagre/board.exp.json +++ b/e2etests/testdata/txtar/cycle-diagram/dagre/board.exp.json @@ -864,8 +864,8 @@ "y": -37.47600173950195 }, { - "x": 195.6020050048828, - "y": -42.86199951171875 + "x": 193.95199584960938, + "y": -52.724998474121094 }, { "x": 197.2519989013672, @@ -1228,8 +1228,8 @@ "y": 197.53700256347656 }, { - "x": 36.4109992980957, - "y": 196.90499877929688 + "x": 46.323001861572266, + "y": 195.5800018310547 }, { "x": 26.5, @@ -1592,8 +1592,8 @@ "y": 37.47600173950195 }, { - "x": -195.6020050048828, - "y": 42.86199951171875 + "x": -193.95199584960938, + "y": 52.724998474121094 }, { "x": -197.2519989013672, @@ -1972,8 +1972,8 @@ "y": 111.8030014038086 }, { - "x": 704.7830200195312, - "y": 107.5770034790039 + "x": 708.1329956054688, + "y": 98.15499877929688 }, { "x": 701.4329833984375, @@ -2336,8 +2336,8 @@ "y": 186.90899658203125 }, { - "x": 370.2919921875, - "y": 190.46800231933594 + "x": 376.9429931640625, + "y": 197.93600463867188 }, { "x": 363.6419982910156, @@ -2740,8 +2740,8 @@ "y": 196.45700073242188 }, { - "x": 1008.4110107421875, - "y": 196.89300537109375 + "x": 1018.322998046875, + "y": 195.5679931640625 }, { "x": 998.5, diff --git a/e2etests/testdata/txtar/cycle-diagram/dagre/sketch.exp.svg b/e2etests/testdata/txtar/cycle-diagram/dagre/sketch.exp.svg index 037adcdac..8a8b6166a 100644 --- a/e2etests/testdata/txtar/cycle-diagram/dagre/sketch.exp.svg +++ b/e2etests/testdata/txtar/cycle-diagram/dagre/sketch.exp.svg @@ -1,9 +1,9 @@ -abcdabcab + .d2-1335890465 .fill-N1{fill:#0A0F25;} + .d2-1335890465 .fill-N2{fill:#676C7E;} + .d2-1335890465 .fill-N3{fill:#9499AB;} + .d2-1335890465 .fill-N4{fill:#CFD2DD;} + .d2-1335890465 .fill-N5{fill:#DEE1EB;} + .d2-1335890465 .fill-N6{fill:#EEF1F8;} + .d2-1335890465 .fill-N7{fill:#FFFFFF;} + .d2-1335890465 .fill-B1{fill:#0D32B2;} + .d2-1335890465 .fill-B2{fill:#0D32B2;} + .d2-1335890465 .fill-B3{fill:#E3E9FD;} + .d2-1335890465 .fill-B4{fill:#E3E9FD;} + .d2-1335890465 .fill-B5{fill:#EDF0FD;} + .d2-1335890465 .fill-B6{fill:#F7F8FE;} + .d2-1335890465 .fill-AA2{fill:#4A6FF3;} + .d2-1335890465 .fill-AA4{fill:#EDF0FD;} + .d2-1335890465 .fill-AA5{fill:#F7F8FE;} + .d2-1335890465 .fill-AB4{fill:#EDF0FD;} + .d2-1335890465 .fill-AB5{fill:#F7F8FE;} + .d2-1335890465 .stroke-N1{stroke:#0A0F25;} + .d2-1335890465 .stroke-N2{stroke:#676C7E;} + .d2-1335890465 .stroke-N3{stroke:#9499AB;} + .d2-1335890465 .stroke-N4{stroke:#CFD2DD;} + .d2-1335890465 .stroke-N5{stroke:#DEE1EB;} + .d2-1335890465 .stroke-N6{stroke:#EEF1F8;} + .d2-1335890465 .stroke-N7{stroke:#FFFFFF;} + .d2-1335890465 .stroke-B1{stroke:#0D32B2;} + .d2-1335890465 .stroke-B2{stroke:#0D32B2;} + .d2-1335890465 .stroke-B3{stroke:#E3E9FD;} + .d2-1335890465 .stroke-B4{stroke:#E3E9FD;} + .d2-1335890465 .stroke-B5{stroke:#EDF0FD;} + .d2-1335890465 .stroke-B6{stroke:#F7F8FE;} + .d2-1335890465 .stroke-AA2{stroke:#4A6FF3;} + .d2-1335890465 .stroke-AA4{stroke:#EDF0FD;} + .d2-1335890465 .stroke-AA5{stroke:#F7F8FE;} + .d2-1335890465 .stroke-AB4{stroke:#EDF0FD;} + .d2-1335890465 .stroke-AB5{stroke:#F7F8FE;} + .d2-1335890465 .background-color-N1{background-color:#0A0F25;} + .d2-1335890465 .background-color-N2{background-color:#676C7E;} + .d2-1335890465 .background-color-N3{background-color:#9499AB;} + .d2-1335890465 .background-color-N4{background-color:#CFD2DD;} + .d2-1335890465 .background-color-N5{background-color:#DEE1EB;} + .d2-1335890465 .background-color-N6{background-color:#EEF1F8;} + .d2-1335890465 .background-color-N7{background-color:#FFFFFF;} + .d2-1335890465 .background-color-B1{background-color:#0D32B2;} + .d2-1335890465 .background-color-B2{background-color:#0D32B2;} + .d2-1335890465 .background-color-B3{background-color:#E3E9FD;} + .d2-1335890465 .background-color-B4{background-color:#E3E9FD;} + .d2-1335890465 .background-color-B5{background-color:#EDF0FD;} + .d2-1335890465 .background-color-B6{background-color:#F7F8FE;} + .d2-1335890465 .background-color-AA2{background-color:#4A6FF3;} + .d2-1335890465 .background-color-AA4{background-color:#EDF0FD;} + .d2-1335890465 .background-color-AA5{background-color:#F7F8FE;} + .d2-1335890465 .background-color-AB4{background-color:#EDF0FD;} + .d2-1335890465 .background-color-AB5{background-color:#F7F8FE;} + .d2-1335890465 .color-N1{color:#0A0F25;} + .d2-1335890465 .color-N2{color:#676C7E;} + .d2-1335890465 .color-N3{color:#9499AB;} + .d2-1335890465 .color-N4{color:#CFD2DD;} + .d2-1335890465 .color-N5{color:#DEE1EB;} + .d2-1335890465 .color-N6{color:#EEF1F8;} + .d2-1335890465 .color-N7{color:#FFFFFF;} + .d2-1335890465 .color-B1{color:#0D32B2;} + .d2-1335890465 .color-B2{color:#0D32B2;} + .d2-1335890465 .color-B3{color:#E3E9FD;} + .d2-1335890465 .color-B4{color:#E3E9FD;} + .d2-1335890465 .color-B5{color:#EDF0FD;} + .d2-1335890465 .color-B6{color:#F7F8FE;} + .d2-1335890465 .color-AA2{color:#4A6FF3;} + .d2-1335890465 .color-AA4{color:#EDF0FD;} + .d2-1335890465 .color-AA5{color:#F7F8FE;} + .d2-1335890465 .color-AB4{color:#EDF0FD;} + .d2-1335890465 .color-AB5{color:#F7F8FE;}.appendix text.text{fill:#0A0F25}.md{--color-fg-default:#0A0F25;--color-fg-muted:#676C7E;--color-fg-subtle:#9499AB;--color-canvas-default:#FFFFFF;--color-canvas-subtle:#EEF1F8;--color-border-default:#0D32B2;--color-border-muted:#0D32B2;--color-neutral-muted:#EEF1F8;--color-accent-fg:#0D32B2;--color-accent-emphasis:#0D32B2;--color-attention-subtle:#676C7E;--color-danger-fg:red;}.sketch-overlay-B1{fill:url(#streaks-darker-d2-1335890465);mix-blend-mode:lighten}.sketch-overlay-B2{fill:url(#streaks-darker-d2-1335890465);mix-blend-mode:lighten}.sketch-overlay-B3{fill:url(#streaks-bright-d2-1335890465);mix-blend-mode:darken}.sketch-overlay-B4{fill:url(#streaks-bright-d2-1335890465);mix-blend-mode:darken}.sketch-overlay-B5{fill:url(#streaks-bright-d2-1335890465);mix-blend-mode:darken}.sketch-overlay-B6{fill:url(#streaks-bright-d2-1335890465);mix-blend-mode:darken}.sketch-overlay-AA2{fill:url(#streaks-dark-d2-1335890465);mix-blend-mode:overlay}.sketch-overlay-AA4{fill:url(#streaks-bright-d2-1335890465);mix-blend-mode:darken}.sketch-overlay-AA5{fill:url(#streaks-bright-d2-1335890465);mix-blend-mode:darken}.sketch-overlay-AB4{fill:url(#streaks-bright-d2-1335890465);mix-blend-mode:darken}.sketch-overlay-AB5{fill:url(#streaks-bright-d2-1335890465);mix-blend-mode:darken}.sketch-overlay-N1{fill:url(#streaks-darker-d2-1335890465);mix-blend-mode:lighten}.sketch-overlay-N2{fill:url(#streaks-dark-d2-1335890465);mix-blend-mode:overlay}.sketch-overlay-N3{fill:url(#streaks-normal-d2-1335890465);mix-blend-mode:color-burn}.sketch-overlay-N4{fill:url(#streaks-normal-d2-1335890465);mix-blend-mode:color-burn}.sketch-overlay-N5{fill:url(#streaks-bright-d2-1335890465);mix-blend-mode:darken}.sketch-overlay-N6{fill:url(#streaks-bright-d2-1335890465);mix-blend-mode:darken}.sketch-overlay-N7{fill:url(#streaks-bright-d2-1335890465);mix-blend-mode:darken}.light-code{display: block}.dark-code{display: none}]]>abcdabcab diff --git a/e2etests/testdata/txtar/cycle-diagram/elk/board.exp.json b/e2etests/testdata/txtar/cycle-diagram/elk/board.exp.json index 94712ff99..bb3b8eaa9 100644 --- a/e2etests/testdata/txtar/cycle-diagram/elk/board.exp.json +++ b/e2etests/testdata/txtar/cycle-diagram/elk/board.exp.json @@ -864,8 +864,8 @@ "y": -25.47599983215332 }, { - "x": 207.6020050048828, - "y": -30.86199951171875 + "x": 205.95199584960938, + "y": -40.724998474121094 }, { "x": 209.2519989013672, @@ -1228,8 +1228,8 @@ "y": 209.53700256347656 }, { - "x": 48.4109992980957, - "y": 208.90499877929688 + "x": 58.323001861572266, + "y": 207.5800018310547 }, { "x": 38.5, @@ -1592,8 +1592,8 @@ "y": 49.47600173950195 }, { - "x": -183.6020050048828, - "y": 54.86199951171875 + "x": -181.95199584960938, + "y": 64.7249984741211 }, { "x": -185.2519989013672, @@ -1972,8 +1972,8 @@ "y": 123.8030014038086 }, { - "x": 677.2830200195312, - "y": 119.5770034790039 + "x": 680.6329956054688, + "y": 110.15499877929688 }, { "x": 673.9329833984375, @@ -2336,8 +2336,8 @@ "y": 198.90899658203125 }, { - "x": 342.7919921875, - "y": 202.46800231933594 + "x": 349.4429931640625, + "y": 209.93600463867188 }, { "x": 336.1419982910156, @@ -2740,8 +2740,8 @@ "y": 208.45700073242188 }, { - "x": 941.3209838867188, - "y": 208.89300537109375 + "x": 951.2329711914062, + "y": 207.5679931640625 }, { "x": 931.4099731445312, diff --git a/e2etests/testdata/txtar/cycle-diagram/elk/sketch.exp.svg b/e2etests/testdata/txtar/cycle-diagram/elk/sketch.exp.svg index c894e3d67..2f3be69dd 100644 --- a/e2etests/testdata/txtar/cycle-diagram/elk/sketch.exp.svg +++ b/e2etests/testdata/txtar/cycle-diagram/elk/sketch.exp.svg @@ -1,9 +1,9 @@ -abcdabcab + .d2-438575134 .fill-N1{fill:#0A0F25;} + .d2-438575134 .fill-N2{fill:#676C7E;} + .d2-438575134 .fill-N3{fill:#9499AB;} + .d2-438575134 .fill-N4{fill:#CFD2DD;} + .d2-438575134 .fill-N5{fill:#DEE1EB;} + .d2-438575134 .fill-N6{fill:#EEF1F8;} + .d2-438575134 .fill-N7{fill:#FFFFFF;} + .d2-438575134 .fill-B1{fill:#0D32B2;} + .d2-438575134 .fill-B2{fill:#0D32B2;} + .d2-438575134 .fill-B3{fill:#E3E9FD;} + .d2-438575134 .fill-B4{fill:#E3E9FD;} + .d2-438575134 .fill-B5{fill:#EDF0FD;} + .d2-438575134 .fill-B6{fill:#F7F8FE;} + .d2-438575134 .fill-AA2{fill:#4A6FF3;} + .d2-438575134 .fill-AA4{fill:#EDF0FD;} + .d2-438575134 .fill-AA5{fill:#F7F8FE;} + .d2-438575134 .fill-AB4{fill:#EDF0FD;} + .d2-438575134 .fill-AB5{fill:#F7F8FE;} + .d2-438575134 .stroke-N1{stroke:#0A0F25;} + .d2-438575134 .stroke-N2{stroke:#676C7E;} + .d2-438575134 .stroke-N3{stroke:#9499AB;} + .d2-438575134 .stroke-N4{stroke:#CFD2DD;} + .d2-438575134 .stroke-N5{stroke:#DEE1EB;} + .d2-438575134 .stroke-N6{stroke:#EEF1F8;} + .d2-438575134 .stroke-N7{stroke:#FFFFFF;} + .d2-438575134 .stroke-B1{stroke:#0D32B2;} + .d2-438575134 .stroke-B2{stroke:#0D32B2;} + .d2-438575134 .stroke-B3{stroke:#E3E9FD;} + .d2-438575134 .stroke-B4{stroke:#E3E9FD;} + .d2-438575134 .stroke-B5{stroke:#EDF0FD;} + .d2-438575134 .stroke-B6{stroke:#F7F8FE;} + .d2-438575134 .stroke-AA2{stroke:#4A6FF3;} + .d2-438575134 .stroke-AA4{stroke:#EDF0FD;} + .d2-438575134 .stroke-AA5{stroke:#F7F8FE;} + .d2-438575134 .stroke-AB4{stroke:#EDF0FD;} + .d2-438575134 .stroke-AB5{stroke:#F7F8FE;} + .d2-438575134 .background-color-N1{background-color:#0A0F25;} + .d2-438575134 .background-color-N2{background-color:#676C7E;} + .d2-438575134 .background-color-N3{background-color:#9499AB;} + .d2-438575134 .background-color-N4{background-color:#CFD2DD;} + .d2-438575134 .background-color-N5{background-color:#DEE1EB;} + .d2-438575134 .background-color-N6{background-color:#EEF1F8;} + .d2-438575134 .background-color-N7{background-color:#FFFFFF;} + .d2-438575134 .background-color-B1{background-color:#0D32B2;} + .d2-438575134 .background-color-B2{background-color:#0D32B2;} + .d2-438575134 .background-color-B3{background-color:#E3E9FD;} + .d2-438575134 .background-color-B4{background-color:#E3E9FD;} + .d2-438575134 .background-color-B5{background-color:#EDF0FD;} + .d2-438575134 .background-color-B6{background-color:#F7F8FE;} + .d2-438575134 .background-color-AA2{background-color:#4A6FF3;} + .d2-438575134 .background-color-AA4{background-color:#EDF0FD;} + .d2-438575134 .background-color-AA5{background-color:#F7F8FE;} + .d2-438575134 .background-color-AB4{background-color:#EDF0FD;} + .d2-438575134 .background-color-AB5{background-color:#F7F8FE;} + .d2-438575134 .color-N1{color:#0A0F25;} + .d2-438575134 .color-N2{color:#676C7E;} + .d2-438575134 .color-N3{color:#9499AB;} + .d2-438575134 .color-N4{color:#CFD2DD;} + .d2-438575134 .color-N5{color:#DEE1EB;} + .d2-438575134 .color-N6{color:#EEF1F8;} + .d2-438575134 .color-N7{color:#FFFFFF;} + .d2-438575134 .color-B1{color:#0D32B2;} + .d2-438575134 .color-B2{color:#0D32B2;} + .d2-438575134 .color-B3{color:#E3E9FD;} + .d2-438575134 .color-B4{color:#E3E9FD;} + .d2-438575134 .color-B5{color:#EDF0FD;} + .d2-438575134 .color-B6{color:#F7F8FE;} + .d2-438575134 .color-AA2{color:#4A6FF3;} + .d2-438575134 .color-AA4{color:#EDF0FD;} + .d2-438575134 .color-AA5{color:#F7F8FE;} + .d2-438575134 .color-AB4{color:#EDF0FD;} + .d2-438575134 .color-AB5{color:#F7F8FE;}.appendix text.text{fill:#0A0F25}.md{--color-fg-default:#0A0F25;--color-fg-muted:#676C7E;--color-fg-subtle:#9499AB;--color-canvas-default:#FFFFFF;--color-canvas-subtle:#EEF1F8;--color-border-default:#0D32B2;--color-border-muted:#0D32B2;--color-neutral-muted:#EEF1F8;--color-accent-fg:#0D32B2;--color-accent-emphasis:#0D32B2;--color-attention-subtle:#676C7E;--color-danger-fg:red;}.sketch-overlay-B1{fill:url(#streaks-darker-d2-438575134);mix-blend-mode:lighten}.sketch-overlay-B2{fill:url(#streaks-darker-d2-438575134);mix-blend-mode:lighten}.sketch-overlay-B3{fill:url(#streaks-bright-d2-438575134);mix-blend-mode:darken}.sketch-overlay-B4{fill:url(#streaks-bright-d2-438575134);mix-blend-mode:darken}.sketch-overlay-B5{fill:url(#streaks-bright-d2-438575134);mix-blend-mode:darken}.sketch-overlay-B6{fill:url(#streaks-bright-d2-438575134);mix-blend-mode:darken}.sketch-overlay-AA2{fill:url(#streaks-dark-d2-438575134);mix-blend-mode:overlay}.sketch-overlay-AA4{fill:url(#streaks-bright-d2-438575134);mix-blend-mode:darken}.sketch-overlay-AA5{fill:url(#streaks-bright-d2-438575134);mix-blend-mode:darken}.sketch-overlay-AB4{fill:url(#streaks-bright-d2-438575134);mix-blend-mode:darken}.sketch-overlay-AB5{fill:url(#streaks-bright-d2-438575134);mix-blend-mode:darken}.sketch-overlay-N1{fill:url(#streaks-darker-d2-438575134);mix-blend-mode:lighten}.sketch-overlay-N2{fill:url(#streaks-dark-d2-438575134);mix-blend-mode:overlay}.sketch-overlay-N3{fill:url(#streaks-normal-d2-438575134);mix-blend-mode:color-burn}.sketch-overlay-N4{fill:url(#streaks-normal-d2-438575134);mix-blend-mode:color-burn}.sketch-overlay-N5{fill:url(#streaks-bright-d2-438575134);mix-blend-mode:darken}.sketch-overlay-N6{fill:url(#streaks-bright-d2-438575134);mix-blend-mode:darken}.sketch-overlay-N7{fill:url(#streaks-bright-d2-438575134);mix-blend-mode:darken}.light-code{display: block}.dark-code{display: none}]]>abcdabcab